modernize cloud code (#642)

* modernize cloud code

* de-duplicate test names

* improves test

Author: flovilmart

integration/cloud/main.js

@@ -1,26 +1,28 @@
 /* global Parse */
-Parse.Cloud.define("bar", function(request, response) {
+Parse.Cloud.define("bar", function(request) {
   if (request.params.key2 === "value1") {
-    response.success('Foo');
+    return 'Foo';
   } else {
-    response.error("bad stuff happened");
+    throw "bad stuff happened";
   }
 });
 
-Parse.Cloud.job('CloudJob1', function(request, response) {
-  response.success({
+Parse.Cloud.job('CloudJob1', function() {
+  return {
     status: 'cloud job completed'
-  });
+  };
 });
 
-Parse.Cloud.job('CloudJob2', function(request, response) {
-  setTimeout(function() {
-    response.success({
-      status: 'cloud job completed'
-    })
-  }, 3000);
+Parse.Cloud.job('CloudJob2', function() {
+  return new Promise((resolve) => {
+    setTimeout(function() {
+      resolve({
+        status: 'cloud job completed'
+      })
+    }, 3000);
+  });
 });
 
-Parse.Cloud.job('CloudJobFailing', function(request, response) {
-  response.error('cloud job failed');
+Parse.Cloud.job('CloudJobFailing', function() {
+  throw 'cloud job failed';
 });

integration/test/ParseGeoPointTest.js

@@ -251,7 +251,7 @@ describe('Geo Point', () => {
     });
   });
 
-  it('can measure distance within km - mid peninsula', (done) => {
+  it('can measure distance within miles - mid peninsula', (done) => {
     const sfo = new Parse.GeoPoint(37.6189722, -122.3748889);
     const query = new Parse.Query(TestPoint);
     query.withinMiles('location', sfo, 10.0);
@@ -406,7 +406,7 @@ describe('Geo Point', () => {
     });
   });
 
-  it('can measure distance within km unsorted - mid peninsula', (done) => {
+  it('can measure distance within miles unsorted - mid peninsula', (done) => {
     const sfo = new Parse.GeoPoint(37.6189722, -122.3748889);
     const query = new Parse.Query(TestPoint);
     query.withinMiles('location', sfo, 10.0, false);

integration/test/ParseQueryTest.js

@@ -46,7 +46,7 @@ describe('Parse Query', () => {
       return query.find();
     }).then((results) => {
       assert.equal(results.length, 1);
-      assert.equal(results[0].get('foo'), 'baz');
+      assert.equal(['baz', 'qux'].includes(results[0].get('foo')), true);
       done();
     }).catch(done.fail);
   });