LDS: Improve Error Handling (#803)

* LDS: Improve Error Handling

Fixes: #773

Should we log key, values?

Console.log vs warn vs error?

* test fix

* test debug

* test mock localstorage

* final test before I give up

* remove mock

* cleanup

Author: dplewis

src/LocalDatastoreController.browser.js

@@ -42,7 +42,11 @@ const LocalDatastoreController = {
       const key = localStorage.key(i);
       if (isLocalDatastoreKey(key)) {
         const value = localStorage.getItem(key);
-        LDS[key] = JSON.parse(value);
+        try {
+          LDS[key] = JSON.parse(value);
+        } catch (error) {
+          console.error('Error getAllContents: ', error);
+        }
       }
     }
     return LDS;

src/__tests__/LocalDatastore-test.js

@@ -6,6 +6,7 @@
  * LICENSE file in the root directory of this source tree. An additional grant
  * of patent rights can be found in the PATENTS file in the same directory.
  */
+/* global window */
 
 jest.autoMockOff();
 jest.unmock('../LocalDatastoreUtils');
@@ -103,10 +104,6 @@ const RNDatastoreController = require('../LocalDatastoreController.react-native'
 const BrowserDatastoreController = require('../LocalDatastoreController.browser');
 const DefaultDatastoreController = require('../LocalDatastoreController.default');
 
-const mockLocalStorage = require('./test_helpers/mockLocalStorage');
-
-global.localStorage = mockLocalStorage;
-
 const item1 = new ParseObject('Item');
 const item2 = new ParseObject('Item');
 const item3 = new ParseObject('Item');
@@ -657,7 +654,6 @@ describe('LocalDatastore', () => {
     user._localId = null;
 
     const USER_KEY = LocalDatastore.getKeyForObject(user);
-    console.log(USER_KEY);
     const LDS = {
       [USER_KEY]: [user._toFullJSON()],
       [`${PIN_PREFIX}_testPinName`]: [USER_KEY],
@@ -872,20 +868,30 @@ describe('LocalDatastore (BrowserDatastoreController)', () => {
     expect(await LocalDatastore._getRawStorage()).toEqual({});
   });
 
+  it('can handle getAllContent error', async () => {
+    await LocalDatastore.pinWithName('_default', [{ value: 'WILL_BE_MOCKED' }]);
+    const windowSpy = jest.spyOn(Object.getPrototypeOf(window.localStorage), 'getItem')
+      .mockImplementationOnce(() => {
+        return '[1, ]';
+      });
+    const spy = jest.spyOn(console, 'error').mockImplementationOnce(() => {});
+    const LDS = await LocalDatastore._getAllContents();
+    expect(LDS).toEqual({});
+    expect(spy).toHaveBeenCalled();
+    spy.mockRestore();
+    windowSpy.mockRestore();
+  });
+
   it('can handle store error', async () => {
-    const mockStorageError = {
-      setItem() {
+    const windowSpy = jest.spyOn(Object.getPrototypeOf(window.localStorage), 'setItem')
+      .mockImplementationOnce(() => {
         throw new Error('error thrown');
-      },
-    };
-    Object.defineProperty(window, 'localStorage', { // eslint-disable-line
-      value: mockStorageError
-    });
-    try {
-      await LocalDatastore.pinWithName('myKey', [{ name: 'test' }]);
-    } catch (e) {
-      expect(e.message).toBe('error thrown');
-    }
+      });
+    const consoleSpy = jest.spyOn(console, 'log').mockImplementationOnce(() => {});
+    await LocalDatastore.pinWithName('myKey', [{ name: 'test' }]);
+    expect(consoleSpy).toHaveBeenCalled();
+    consoleSpy.mockRestore();
+    windowSpy.mockRestore();
   });
 });