fix: Unhandled exception when saving a ParseObject but its nested object fails to save (#858)

Nidal-Bakir · web-flow · commit bdbc4834834d · 2023-03-20T23:19:24.000+01:00
diff --git a/.gitignore b/.gitignore
@@ -102,7 +102,7 @@ unlinked_spec.ds
 
 # macOS
 **/macos/Flutter/GeneratedPluginRegistrant.swift
-**/macos/flutter/ephemeral/
+**/macos/Flutter/ephemeral/
 
 # Linux
 **/linux/flutter/ephemeral
diff --git a/packages/dart/CHANGELOG.md b/packages/dart/CHANGELOG.md
@@ -1,3 +1,9 @@
+## [4.0.1](https://github.com/parse-community/Parse-SDK-Flutter/compare/dart-4.0.0...dart-4.0.1) (2023-03-20)
+
+### Bug Fixes
+
+* Unhandled exception when saving a `ParseObject` but its nested object fails to save ([#858](https://github.com/parse-community/Parse-SDK-Flutter/pull/858))
+
 ## [4.0.0](https://github.com/parse-community/Parse-SDK-Flutter/compare/dart-3.1.14...dart-4.0.0) (2023-03-07)
 
 ### BREAKING CHANGES
diff --git a/packages/dart/lib/src/base/parse_constants.dart b/packages/dart/lib/src/base/parse_constants.dart
@@ -1,7 +1,7 @@
 part of flutter_parse_sdk;
 
 // Library
-const String keySdkVersion = '4.0.0';
+const String keySdkVersion = '4.0.1';
 const String keyLibraryName = 'Flutter Parse SDK';
 
 // End Points
diff --git a/packages/dart/lib/src/objects/response/parse_response_builder.dart b/packages/dart/lib/src/objects/response/parse_response_builder.dart
@@ -54,27 +54,40 @@ class _ParseResponseBuilder {
   }
 
   /// Handles successful response with results
-  ParseResponse _handleSuccess<T>(ParseResponse response, dynamic object,
-      String responseBody, ParseApiRQ type) {
+  ParseResponse _handleSuccess<T>(
+    ParseResponse response,
+    dynamic object,
+    String responseBody,
+    ParseApiRQ type,
+  ) {
     response.success = true;
 
     final dynamic result = json.decode(responseBody);
 
     if (type == ParseApiRQ.batch) {
       final List<dynamic>? list = result;
+
       if (object is List && object.length == list!.length) {
         response.count = object.length;
         response.results = <dynamic>[];
+
         for (int i = 0; i < object.length; i++) {
           final Map<String, dynamic> objectResult = list[i];
+
           if (objectResult.containsKey('success')) {
             final T? item = _handleSingleResult<T>(
-                object[i], objectResult['success'], false);
+              object[i],
+              objectResult['success'],
+              false,
+            );
+
             response.results!.add(item);
           } else {
             final ParseError error = ParseError(
-                code: objectResult[keyCode],
-                message: objectResult[keyError].toString());
+              code: objectResult[keyError][keyCode],
+              message: objectResult[keyError][keyError].toString(),
+            );
+
             response.results!.add(error);
           }
         }
diff --git a/packages/dart/pubspec.yaml b/packages/dart/pubspec.yaml
@@ -1,6 +1,6 @@
 name: parse_server_sdk
 description: Dart plugin for Parse Server, (https://parseplatform.org), (https://back4app.com)
-version: 4.0.0
+version: 4.0.1
 homepage: https://github.com/parse-community/Parse-SDK-Flutter
 
 environment:
diff --git a/packages/dart/test/src/objects/parse_object/parse_object_array_test.dart b/packages/dart/test/src/objects/parse_object/parse_object_array_test.dart
@@ -8,7 +8,6 @@ import 'package:parse_server_sdk/parse_server_sdk.dart';
 import 'package:test/test.dart';
 
 import '../../../parse_query_test.mocks.dart';
-import 'parse_object_test.dart';
 import '../../../test_utils.dart';
 
 void main() {
diff --git a/packages/dart/test/src/objects/parse_object/parse_object_create_test.dart b/packages/dart/test/src/objects/parse_object/parse_object_create_test.dart
@@ -5,7 +5,7 @@ import 'package:parse_server_sdk/parse_server_sdk.dart';
 import 'package:test/test.dart';
 
 import '../../../parse_query_test.mocks.dart';
-import 'parse_object_test.dart';
+import '../../../test_utils.dart';
 
 void main() {
   group('create()', () {
diff --git a/packages/dart/test/src/objects/parse_object/parse_object_delete_test.dart b/packages/dart/test/src/objects/parse_object/parse_object_delete_test.dart
@@ -5,7 +5,7 @@ import 'package:parse_server_sdk/parse_server_sdk.dart';
 import 'package:test/test.dart';
 
 import '../../../parse_query_test.mocks.dart';
-import 'parse_object_test.dart';
+import '../../../test_utils.dart';
 
 void main() {
   group('delete()', () {
diff --git a/packages/dart/test/src/objects/parse_object/parse_object_distinct_test.dart b/packages/dart/test/src/objects/parse_object/parse_object_distinct_test.dart
@@ -5,7 +5,7 @@ import 'package:parse_server_sdk/parse_server_sdk.dart';
 import 'package:test/test.dart';
 
 import '../../../parse_query_test.mocks.dart';
-import 'parse_object_test.dart';
+import '../../../test_utils.dart';
 
 void main() {
   group('distinct()', () {
diff --git a/packages/dart/test/src/objects/parse_object/parse_object_fetch_test.dart b/packages/dart/test/src/objects/parse_object/parse_object_fetch_test.dart
@@ -5,7 +5,7 @@ import 'package:parse_server_sdk/parse_server_sdk.dart';
 import 'package:test/test.dart';
 
 import '../../../parse_query_test.mocks.dart';
-import 'parse_object_test.dart';
+import '../../../test_utils.dart';
 
 void main() {
   group('fetch()', () {
diff --git a/packages/dart/test/src/objects/parse_object/parse_object_get_all_test.dart b/packages/dart/test/src/objects/parse_object/parse_object_get_all_test.dart
@@ -5,7 +5,7 @@ import 'package:parse_server_sdk/parse_server_sdk.dart';
 import 'package:test/test.dart';
 
 import '../../../parse_query_test.mocks.dart';
-import 'parse_object_test.dart';
+import '../../../test_utils.dart';
 
 void main() {
   group('getAll()', () {
diff --git a/packages/dart/test/src/objects/parse_object/parse_object_get_object_test.dart b/packages/dart/test/src/objects/parse_object/parse_object_get_object_test.dart
@@ -5,7 +5,7 @@ import 'package:parse_server_sdk/parse_server_sdk.dart';
 import 'package:test/test.dart';
 
 import '../../../parse_query_test.mocks.dart';
-import 'parse_object_test.dart';
+import '../../../test_utils.dart';
 
 void main() {
   group('getObject()', () {
diff --git a/packages/dart/test/src/objects/parse_object/parse_object_increment_decrement_test.dart b/packages/dart/test/src/objects/parse_object/parse_object_increment_decrement_test.dart
@@ -7,7 +7,6 @@ import 'package:parse_server_sdk/parse_server_sdk.dart';
 import 'package:test/test.dart';
 
 import '../../../parse_query_test.mocks.dart';
-import 'parse_object_test.dart';
 import '../../../test_utils.dart';
 
 void main() {
diff --git a/packages/dart/test/src/objects/parse_object/parse_object_query_test.dart b/packages/dart/test/src/objects/parse_object/parse_object_query_test.dart
@@ -5,7 +5,7 @@ import 'package:parse_server_sdk/parse_server_sdk.dart';
 import 'package:test/test.dart';
 
 import '../../../parse_query_test.mocks.dart';
-import 'parse_object_test.dart';
+import '../../../test_utils.dart';
 
 void main() {
   group('query()', () {
diff --git a/packages/dart/test/src/objects/parse_object/parse_object_relation_test.dart b/packages/dart/test/src/objects/parse_object/parse_object_relation_test.dart
@@ -2,7 +2,6 @@ import 'package:collection/collection.dart';
 import 'package:parse_server_sdk/parse_server_sdk.dart';
 import 'package:test/test.dart';
 
-import 'parse_object_test.dart';
 import '../../../test_utils.dart';
 
 void main() {
diff --git a/packages/dart/test/src/objects/parse_object/parse_object_save_test.dart b/packages/dart/test/src/objects/parse_object/parse_object_save_test.dart
@@ -5,7 +5,7 @@ import 'package:parse_server_sdk/parse_server_sdk.dart';
 import 'package:test/test.dart';
 
 import '../../../parse_query_test.mocks.dart';
-import 'parse_object_test.dart';
+import '../../../test_utils.dart';
 
 void main() {
   group('save()', () {
diff --git a/packages/dart/test/src/objects/parse_object/parse_object_test.dart b/packages/dart/test/src/objects/parse_object/parse_object_test.dart
@@ -2,23 +2,7 @@ import 'package:mockito/annotations.dart';
 import 'package:parse_server_sdk/parse_server_sdk.dart';
 import 'package:test/test.dart';
 
-const serverUrl = 'https://example.com';
-
-Future<void> initializeParse() async {
-  await Parse().initialize(
-    'appId',
-    serverUrl,
-    debug: true,
-    // to prevent automatic detection
-    fileDirectory: 'someDirectory',
-    // to prevent automatic detection
-    appName: 'appName',
-    // to prevent automatic detection
-    appPackageName: 'somePackageName',
-    // to prevent automatic detection
-    appVersion: 'someAppVersion',
-  );
-}
+import '../../../test_utils.dart';
 
 @GenerateMocks([ParseClient])
 void main() {
diff --git a/packages/dart/test/src/objects/parse_object/parse_object_unset_test.dart b/packages/dart/test/src/objects/parse_object/parse_object_unset_test.dart
@@ -5,7 +5,7 @@ import 'package:parse_server_sdk/parse_server_sdk.dart';
 import 'package:test/test.dart';
 
 import '../../../parse_query_test.mocks.dart';
-import 'parse_object_test.dart';
+import '../../../test_utils.dart';
 
 void main() {
   group('unset()', () {
diff --git a/packages/dart/test/src/objects/parse_object/parse_object_update_test.dart b/packages/dart/test/src/objects/parse_object/parse_object_update_test.dart
@@ -5,7 +5,7 @@ import 'package:parse_server_sdk/parse_server_sdk.dart';
 import 'package:test/test.dart';
 
 import '../../../parse_query_test.mocks.dart';
-import 'parse_object_test.dart';
+import '../../../test_utils.dart';
 
 void main() {
   group('update()', () {
diff --git a/packages/dart/test/src/objects/response/parse_response_utils_test.dart b/packages/dart/test/src/objects/response/parse_response_utils_test.dart
@@ -0,0 +1,164 @@
+import 'dart:convert';
+
+import 'package:parse_server_sdk/parse_server_sdk.dart';
+import 'package:test/test.dart';
+
+import '../../../test_utils.dart';
+
+void main() {
+  group('handleResponse()', () {
+    setUp(() async {
+      await initializeParse();
+    });
+
+    group('when batch', () {
+      test(
+          'should return a ParseResponse holds a list of created/updated ParseObjects',
+          () {
+        // arrange
+        final object1 = ParseObject("object1");
+
+        final object2 = ParseObject("object2")..objectId = "GYfSRRRXbL";
+
+        final objectsToBatch = [object1, object2];
+
+        const object1ResultFromServerObjectId = "YAfSAWwXbL";
+        const object1ResultFromServerCreatedAt = "2023-03-19T00:20:37.187Z";
+
+        const object2ResultFromServerUpdatedAt = "2023-03-19T00:20:37.187Z";
+
+        final resultFromServerForBatch = json.encode(
+          [
+            {
+              "success": {
+                keyVarObjectId: object1ResultFromServerObjectId,
+                keyVarCreatedAt: object1ResultFromServerCreatedAt,
+              }
+            },
+            {
+              "success": {
+                keyVarUpdatedAt: object2ResultFromServerUpdatedAt,
+              }
+            }
+          ],
+        );
+
+        final result = ParseNetworkResponse(
+          data: resultFromServerForBatch,
+          statusCode: 200,
+        );
+
+        // act
+        final response = handleResponse(
+          objectsToBatch,
+          result,
+          ParseApiRQ.batch,
+          true,
+          'test_batch',
+        );
+
+        // assert
+        expect(response.success, isTrue);
+
+        expect(response.count, equals(2));
+
+        expect(response.error, isNull);
+
+        final resultsObjectsList = List<ParseObject>.from(response.results!);
+
+        expect(resultsObjectsList.length, equals(2));
+
+        final firstObject = resultsObjectsList[0];
+        final secondObject = resultsObjectsList[1];
+
+        expect(firstObject.objectId, equals(object1ResultFromServerObjectId));
+
+        expect(
+          firstObject.createdAt!.toIso8601String(),
+          equals(object1ResultFromServerCreatedAt),
+        );
+
+        expect(
+          secondObject.updatedAt!.toIso8601String(),
+          equals(object2ResultFromServerUpdatedAt),
+        );
+      });
+
+      test(
+          'should return a ParseResponse holds a list of ParseObject and ParseError',
+          () {
+        // arrange
+        final object1 = ParseObject("object1");
+        final object2 = ParseObject("object2");
+
+        final objectsToBatch = [object1, object2];
+
+        const object1ResultFromServerObjectId = "YAfSAWwXbL";
+        const object1ResultFromServerCreatedAt = "2023-03-19T00:20:37.187Z";
+
+        final resultFromServerForBatch = json.encode(
+          [
+            {
+              "success": {
+                keyVarObjectId: object1ResultFromServerObjectId,
+                keyVarCreatedAt: object1ResultFromServerCreatedAt,
+              }
+            },
+            // error while saving the second object
+            {
+              "error": {
+                "code": ParseError.internalServerError,
+                "error": "internal server error",
+              }
+            }
+          ],
+        );
+
+        final result = ParseNetworkResponse(
+          data: resultFromServerForBatch,
+          statusCode: 200,
+        );
+
+        // act
+        final response = handleResponse(
+          objectsToBatch,
+          result,
+          ParseApiRQ.batch,
+          true,
+          'test_batch',
+        );
+
+        // assert
+        expect(response.success, isTrue);
+
+        expect(response.count, equals(2));
+
+        expect(response.error, isNull);
+
+        expect(response.results, isNotNull);
+
+        final resultsList = response.results!;
+
+        expect(resultsList.length, equals(2));
+
+        final ParseObject firstObject = resultsList[0];
+
+        final ParseError secondObjectError = resultsList[1];
+
+        expect(firstObject.objectId, equals(object1ResultFromServerObjectId));
+
+        expect(
+          firstObject.createdAt!.toIso8601String(),
+          equals(object1ResultFromServerCreatedAt),
+        );
+
+        expect(
+          secondObjectError.code,
+          equals(ParseError.internalServerError),
+        );
+
+        expect(object2.objectId, isNull);
+      });
+    });
+  });
+}
diff --git a/packages/dart/test/test_utils.dart b/packages/dart/test/test_utils.dart
