Skip to content

Commit b695f37

Browse files
phillwigginsphillwiggins
committed
Release 1.0.27 - Pre-release process
- Static analysis fixes
1 parent 039cf29 commit b695f37

File tree

6 files changed

+29
-18
lines changed

6 files changed

+29
-18
lines changed

‎example/lib/pages/home_page.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ class _HomePageState extends State<HomePage> {
4141
title: const Text('Parse Server demo'),
4242
actions: <Widget>[
4343
FlatButton(
44-
child: Text('Logout',
44+
child: const Text('Logout',
4545
style: TextStyle(fontSize: 17.0, color: Colors.white)),
4646
onPressed: () async {
4747
final ParseUser user = await ParseUser.currentUser();

‎example_livelist/lib/main.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ class _ObjectFormState extends State<ObjectForm> {
172172
],
173173
),
174174
trailing: IconButton(
175-
icon: Icon(Icons.save),
175+
icon: const Icon(Icons.save),
176176
onPressed: () {
177177
setState(() {
178178
_formKey.currentState.save();

‎lib/src/data/parse_subclass_handler.dart‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,12 @@ class ParseSubClassHandler {
4747
}
4848

4949
ParseObject createObject(String classname) {
50-
if (classname == keyClassUser) return createParseUser(null, null, null);
51-
if (_subClassMap.containsKey(classname)) return _subClassMap[classname]();
50+
if (classname == keyClassUser) {
51+
return createParseUser(null, null, null);
52+
}
53+
if (_subClassMap.containsKey(classname)) {
54+
return _subClassMap[classname]();
55+
}
5256
return ParseObject(classname);
5357
}
5458

‎lib/src/network/parse_query.dart‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -301,7 +301,7 @@ class QueryBuilder<T extends ParseObject> {
301301
// Add a constraint to the query that requires a particular key's value matches a value for a key in the results of another ParseQuery.
302302
// ignore: always_specify_types
303303
void whereMatchesKeyInQuery(
304-
String column, String keyInQuery, QueryBuilder query) {
304+
String column, String keyInQuery, QueryBuilder<T> query) {
305305
if (query.queries.isEmpty) {
306306
throw ArgumentError('query conditions is required');
307307
}
@@ -322,7 +322,7 @@ class QueryBuilder<T extends ParseObject> {
322322
// Add a constraint to the query that requires a particular key's value does not match any value for a key in the results of another ParseQuery
323323
// ignore: always_specify_types
324324
void whereDoesNotMatchKeyInQuery(
325-
String column, String keyInQuery, QueryBuilder query) {
325+
String column, String keyInQuery, QueryBuilder<T> query) {
326326
if (query.queries.isEmpty) {
327327
throw ArgumentError('query conditions is required');
328328
}

‎lib/src/objects/response/parse_response_builder.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,6 @@ class _ParseResponseBuilder {
151151
}
152152

153153
bool isHealthCheck(Response apiResponse) {
154-
return ['{\"status\":\"ok\"}', 'OK'].contains(apiResponse.body);
154+
return <String>['{\"status\":\"ok\"}', 'OK'].contains(apiResponse.body);
155155
}
156156
}

‎lib/src/utils/parse_live_list.dart‎

Lines changed: 18 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,9 @@ class ParseLiveList<T extends ParseObject> {
256256

257257
static Future<void> _loadIncludes(ParseObject object,
258258
{ParseObject oldObject, Map<String, dynamic> paths}) async {
259-
if (object == null || paths == null || paths.isEmpty) return;
259+
if (object == null || paths == null || paths.isEmpty) {
260+
return;
261+
}
260262

261263
final List<Future<void>> loadingNodes = <Future<void>>[];
262264

@@ -284,11 +286,13 @@ class ParseLiveList<T extends ParseObject> {
284286
.then<void>((ParseResponse parseResponse) {
285287
if (parseResponse.success &&
286288
parseResponse.results.length == 1) {
289+
// ignore: deprecated_member_use_from_same_package
287290
object.getObjectData()[key] = parseResponse.results[0];
288291
}
289292
}));
290293
continue;
291294
} else {
295+
// ignore: deprecated_member_use_from_same_package
292296
object.getObjectData()[key] = includedObject;
293297
//recursion
294298
loadingNodes
@@ -305,6 +309,7 @@ class ParseLiveList<T extends ParseObject> {
305309
loadingNodes.add(
306310
queryBuilder.query().then<void>((ParseResponse parseResponse) {
307311
if (parseResponse.success && parseResponse.results.length == 1) {
312+
// ignore: deprecated_member_use_from_same_package
308313
object.getObjectData()[key] = parseResponse.results[0];
309314
}
310315
}));
@@ -331,7 +336,7 @@ class ParseLiveList<T extends ParseObject> {
331336
// ignore: avoid_as
332337
if ((includes[key] as Map<String, dynamic>).isNotEmpty) {
333338
includeList
334-
.addAll(_toIncludeStringList(includes[key]).map((e) => '$key.$e'));
339+
.addAll(_toIncludeStringList(includes[key]).map((String e) => '$key.$e'));
335340
}
336341
}
337342
return includeList;
@@ -343,7 +348,9 @@ class ParseLiveList<T extends ParseObject> {
343348
//(Hide first element, hide second, view first, view second => second is displayed twice)
344349
object = object?.clone(object?.toJson(full: true));
345350

346-
if (!fetchedIncludes) await _loadIncludes(object, paths: _includePaths);
351+
if (!fetchedIncludes) {
352+
await _loadIncludes(object, paths: _includePaths);
353+
}
347354
for (int i = 0; i < _list.length; i++) {
348355
if (after(object, _list[i].object) != true) {
349356
_list.insert(
@@ -604,6 +611,7 @@ class ParseLiveListElement<T extends ParseObject> {
604611
_subscriptionQueue.whenComplete(() async {
605612
await ParseLiveList._loadIncludes(newObject,
606613
oldObject: subObject, paths: _toKeyMap(path));
614+
// ignore: deprecated_member_use_from_same_package
607615
parentObject.getObjectData()[currentKey.key] = newObject;
608616
if (!_streamController.isClosed) {
609617
_streamController
@@ -667,21 +675,20 @@ class ParseLiveListElement<T extends ParseObject> {
667675
if (subObject?.containsKey(keyVarUpdatedAt) == true) {
668676
final QueryBuilder<ParseObject> queryBuilder =
669677
QueryBuilder<ParseObject>(subObject)
670-
..keysToReturn([keyVarUpdatedAt])
678+
..keysToReturn(<String>[keyVarUpdatedAt])
671679
..whereEqualTo(keyVarObjectId, subObject.objectId);
672-
ParseResponse parseResponse = await queryBuilder.query();
673-
if (parseResponse.success &&
674-
(parseResponse.results.first as ParseObject).updatedAt !=
680+
final ParseResponse parseResponse = await queryBuilder.query();
681+
if (parseResponse.success && parseResponse.results.first.updatedAt !=
675682
subObject.updatedAt) {
676-
queryBuilder.limiters.remove("keys");
683+
queryBuilder.limiters.remove('keys');
677684
queryBuilder.includeObject(_getIncludeList(path[key]));
678-
ParseResponse parseResponse = await queryBuilder.query();
685+
final ParseResponse parseResponse = await queryBuilder.query();
679686
if (parseResponse.success) {
680687
subObject = parseResponse.result.first;
681688
// root.getObjectData()[key.key] = subObject;
682-
if (key.subscription?.eventCallbacks?.containsKey("update") ==
689+
if (key.subscription?.eventCallbacks?.containsKey('update') ==
683690
true) {
684-
key.subscription.eventCallbacks["update"](subObject);
691+
key.subscription.eventCallbacks['update'](subObject);
685692
}
686693
// key.subscription.eventCallbacks["update"](subObject);
687694
break;

0 commit comments

Comments
 (0)