Remove default content-type, only set if explicitly provided

Copilot · mtrezza · Copilot · commit ae68a7a382fe · 2025-11-24T12:45:17.000Z
Changed ParseXFile and ParseFile to not set any default content-type header. Content-type is now only set if explicitly provided (e.g., via file.mimeType in XFile). This allows Parse Server to always infer the MIME type from the file extension, addressing feedback from @mtrezza. Co-authored-by: mtrezza <5673677+mtrezza@users.noreply.github.com>
diff --git a/packages/dart/lib/src/objects/parse_file.dart b/packages/dart/lib/src/objects/parse_file.dart
@@ -4,15 +4,14 @@ class ParseFile extends ParseFileBase {
   /// Creates a new file
   ///
   /// {https://docs.parseplatform.org/rest/guide/#files/}
-  ParseFile(this.file,
-      {String? name,
-      super.url,
-      super.debug,
-      super.client,
-      super.autoSendSessionId})
-      : super(
-          name: name ?? path.basename(file?.path ?? ''),
-        );
+  ParseFile(
+    this.file, {
+    String? name,
+    super.url,
+    super.debug,
+    super.client,
+    super.autoSendSessionId,
+  }) : super(name: name ?? path.basename(file?.path ?? ''));
 
   File? file;
   CancelToken? _cancelToken;
@@ -62,14 +61,15 @@ class ParseFile extends ParseFileBase {
       //Creates a Fake Response to return the correct result
       final Map<String, String> response = <String, String>{
         'url': url!,
-        'name': name
+        'name': name,
       };
       return handleResponse<ParseFile>(
-          this,
-          ParseNetworkResponse(data: json.encode(response), statusCode: 201),
-          ParseApiRQ.upload,
-          _debug,
-          parseClassName);
+        this,
+        ParseNetworkResponse(data: json.encode(response), statusCode: 201),
+        ParseApiRQ.upload,
+        _debug,
+        parseClassName,
+      );
     }
 
     progressCallback ??= _progressCallback;
@@ -80,14 +80,7 @@ class ParseFile extends ParseFileBase {
       HttpHeaders.contentLengthHeader: '${file!.lengthSync()}',
     };
 
-    // Only set content-type if the file has no extension
-    // If extension exists, let the server infer the MIME type from the filename
-    final bool hasExtension = path.extension(name).isNotEmpty;
-
-    if (!hasExtension) {
-      // No extension, set content-type to application/octet-stream as fallback
-      headers[HttpHeaders.contentTypeHeader] = 'application/octet-stream';
-    }
+    // Do not set content-type - let the server infer it from the filename
 
     try {
       final String uri = ParseCoreData().serverUrl + _path;
@@ -105,7 +98,12 @@ class ParseFile extends ParseFileBase {
       }
 
       return handleResponse<ParseFile>(
-          this, response, ParseApiRQ.upload, _debug, parseClassName);
+        this,
+        response,
+        ParseApiRQ.upload,
+        _debug,
+        parseClassName,
+      );
     } on Exception catch (e) {
       return handleException(e, ParseApiRQ.upload, _debug, parseClassName);
     }
diff --git a/packages/dart/lib/src/objects/parse_x_file.dart b/packages/dart/lib/src/objects/parse_x_file.dart
@@ -4,15 +4,14 @@ class ParseXFile extends ParseFileBase {
   /// Creates a new file base XFile
   ///
   /// {https://docs.parseplatform.org/rest/guide/#files/}
-  ParseXFile(this.file,
-      {String? name,
-      super.url,
-      super.debug,
-      super.client,
-      super.autoSendSessionId})
-      : super(
-          name: name ?? path.basename(file?.path ?? ''),
-        );
+  ParseXFile(
+    this.file, {
+    String? name,
+    super.url,
+    super.debug,
+    super.client,
+    super.autoSendSessionId,
+  }) : super(name: name ?? path.basename(file?.path ?? ''));
 
   XFile? file;
   CancelToken? _cancelToken;
@@ -79,28 +78,26 @@ class ParseXFile extends ParseFileBase {
       //Creates a Fake Response to return the correct result
       final Map<String, String> response = <String, String>{
         'url': url!,
-        'name': name
+        'name': name,
       };
       return handleResponse<ParseXFile>(
-          this,
-          ParseNetworkResponse(data: json.encode(response), statusCode: 201),
-          ParseApiRQ.upload,
-          _debug,
-          parseClassName);
+        this,
+        ParseNetworkResponse(data: json.encode(response), statusCode: 201),
+        ParseApiRQ.upload,
+        _debug,
+        parseClassName,
+      );
     }
 
     progressCallback ??= _progressCallback;
 
     _cancelToken = CancelToken();
     Map<String, String> headers = <String, String>{};
 
-    // Only set content-type if the file has no extension
-    // If extension exists, let the server infer the MIME type from the filename
-    final bool hasExtension = path.extension(name).isNotEmpty;
-
-    if (!hasExtension) {
-      // No extension, set content-type to application/octet-stream as fallback
-      headers[HttpHeaders.contentTypeHeader] = 'application/octet-stream';
+    // Only set content-type if explicitly provided by the XFile
+    // Otherwise, let the server infer the MIME type from the filename
+    if (file?.mimeType != null) {
+      headers[HttpHeaders.contentTypeHeader] = file!.mimeType!;
     }
 
     if (!parseIsWeb) {
@@ -112,8 +109,9 @@ class ParseXFile extends ParseFileBase {
 
       Stream<List<int>>? data;
       if (parseIsWeb) {
-        data = Stream<List<int>>.fromIterable(
-            <List<int>>[await file!.readAsBytes()]);
+        data = Stream<List<int>>.fromIterable(<List<int>>[
+          await file!.readAsBytes(),
+        ]);
       } else {
         data = file!.openRead();
       }
@@ -131,7 +129,12 @@ class ParseXFile extends ParseFileBase {
         name = map['name'].toString();
       }
       return handleResponse<ParseXFile>(
-          this, response, ParseApiRQ.upload, _debug, parseClassName);
+        this,
+        response,
+        ParseApiRQ.upload,
+        _debug,
+        parseClassName,
+      );
     } on Exception catch (e) {
       return handleException(e, ParseApiRQ.upload, _debug, parseClassName);
     }
diff --git a/packages/dart/test/src/objects/parse_file_test.dart b/packages/dart/test/src/objects/parse_file_test.dart
@@ -1,7 +1,6 @@
 import 'dart:io';
 import 'package:parse_server_sdk/parse_server_sdk.dart';
 import 'package:test/test.dart';
-import 'package:path/path.dart' as path;
 
 import '../../test_utils.dart';
 
@@ -17,8 +16,7 @@ void main() {
       expect(parseFile.name, 'bb.jpg');
     });
 
-    test('should detect file extension correctly for files with extensions',
-        () {
+    test('should handle files with various extensions', () {
       // Test various file extensions
       final testCases = [
         'image.jpg',
@@ -31,28 +29,20 @@ void main() {
       for (final filename in testCases) {
         File file = File('/path/to/$filename');
         final parseFile = ParseFile(file, name: filename);
-        // Verify that the extension is detected
-        expect(path.extension(parseFile.name).isNotEmpty, true,
-            reason: '$filename should have an extension');
+        // Verify that the name is set correctly
+        expect(parseFile.name, filename);
       }
     });
 
-    test(
-        'should detect missing extension correctly for files without extensions',
-        () {
+    test('should handle files without extensions', () {
       // Test files without extensions
-      final testCases = [
-        'image',
-        'file',
-        'document',
-      ];
+      final testCases = ['image', 'file', 'document'];
 
       for (final filename in testCases) {
         File file = File('/path/to/$filename');
         final parseFile = ParseFile(file, name: filename);
-        // Verify that no extension is detected
-        expect(path.extension(parseFile.name).isEmpty, true,
-            reason: '$filename should not have an extension');
+        // Verify that the name is set correctly
+        expect(parseFile.name, filename);
       }
     });
   });
diff --git a/packages/dart/test/src/objects/parse_x_file_test.dart b/packages/dart/test/src/objects/parse_x_file_test.dart
@@ -1,7 +1,6 @@
 import 'package:cross_file/cross_file.dart';
 import 'package:parse_server_sdk/parse_server_sdk.dart';
 import 'package:test/test.dart';
-import 'package:path/path.dart' as path;
 
 import '../../test_utils.dart';
 
@@ -17,8 +16,7 @@ void main() {
       expect(parseFile.name, 'bb.jpg');
     });
 
-    test('should detect file extension correctly for files with extensions',
-        () {
+    test('should handle files with various extensions', () {
       // Test various file extensions
       final testCases = [
         'image.jpg',
@@ -31,28 +29,20 @@ void main() {
       for (final filename in testCases) {
         XFile file = XFile('/path/to/$filename');
         final parseFile = ParseXFile(file, name: filename);
-        // Verify that the extension is detected
-        expect(path.extension(parseFile.name).isNotEmpty, true,
-            reason: '$filename should have an extension');
+        // Verify that the name is set correctly
+        expect(parseFile.name, filename);
       }
     });
 
-    test(
-        'should detect missing extension correctly for files without extensions',
-        () {
+    test('should handle files without extensions', () {
       // Test files without extensions
-      final testCases = [
-        'image',
-        'file',
-        'document',
-      ];
+      final testCases = ['image', 'file', 'document'];
 
       for (final filename in testCases) {
         XFile file = XFile('/path/to/$filename');
         final parseFile = ParseXFile(file, name: filename);
-        // Verify that no extension is detected
-        expect(path.extension(parseFile.name).isEmpty, true,
-            reason: '$filename should not have an extension');
+        // Verify that the name is set correctly
+        expect(parseFile.name, filename);
       }
     });
   });
