Skip to content

Commit 426a8e4

Browse files
rogerhuJawnnypoo
authored andcommitted
Make LogLevel DEBUG instead of VERBOSE for FCM/GCM registration messages (#814)
* We should make these messages debug logging level. * Add additional logging
1 parent bff5381 commit 426a8e4

File tree

6 files changed

+11
-8
lines changed

6 files changed

+11
-8
lines changed

Parse/src/main/java/com/parse/PLog.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,15 +60,15 @@ private static void log(int messageLogLevel, String tag, String message, Throwab
6060
log(Log.VERBOSE, tag, message, tr);
6161
}
6262

63-
public static void v(String tag, String message) {
63+
static void v(String tag, String message) {
6464
v(tag, message, null);
6565
}
6666

6767
/* package */ static void d(String tag, String message, Throwable tr) {
6868
log(Log.DEBUG, tag, message, tr);
6969
}
7070

71-
/* package */ static void d(String tag, String message) {
71+
/* package */ public static void d(String tag, String message) {
7272
d(tag, message, null);
7373
}
7474

fcm/src/main/java/com/parse/fcm/ParseFCM.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
import com.firebase.jobdispatcher.FirebaseJobDispatcher;
1414
import com.firebase.jobdispatcher.GooglePlayDriver;
1515
import com.firebase.jobdispatcher.Job;
16+
import com.parse.PLog;
1617

1718
public class ParseFCM {
1819

@@ -24,6 +25,8 @@ public class ParseFCM {
2425
* @param context context
2526
*/
2627
public static void register(Context context) {
28+
//kicks off the background job
29+
PLog.d(TAG, "Scheduling job to register Parse FCM");
2730
FirebaseJobDispatcher dispatcher = new FirebaseJobDispatcher(new GooglePlayDriver(context.getApplicationContext()));
2831
Job job = ParseFirebaseJobService.createJob(dispatcher);
2932
dispatcher.mustSchedule(job);

fcm/src/main/java/com/parse/fcm/ParseFirebaseJobService.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ static Job createJob(FirebaseJobDispatcher dispatcher) {
4444

4545
@Override
4646
public boolean onStartJob(final JobParameters job) {
47-
PLog.v(ParseFCM.TAG, "Updating FCM token");
47+
PLog.d(ParseFCM.TAG, "Updating FCM token");
4848
ParseInstallation installation = ParseInstallation.getCurrentInstallation();
4949
String token = FirebaseInstanceId.getInstance().getToken();
5050
if (installation != null && token != null) {
@@ -55,7 +55,7 @@ public boolean onStartJob(final JobParameters job) {
5555
@Override
5656
public void done(ParseException e) {
5757
if (e == null) {
58-
PLog.v(ParseFCM.TAG, "FCM token saved to installation");
58+
PLog.d(ParseFCM.TAG, "FCM token saved to installation");
5959
jobFinished(job, false);
6060
} else {
6161
PLog.e(ParseFCM.TAG, "FCM token upload failed", e);

fcm/src/main/java/com/parse/fcm/ParseFirebaseMessagingService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ public class ParseFirebaseMessagingService extends FirebaseMessagingService {
1313
@Override
1414
public void onMessageReceived(RemoteMessage remoteMessage) {
1515
super.onMessageReceived(remoteMessage);
16-
PLog.v(ParseFCM.TAG, "onMessageReceived");
16+
PLog.d(ParseFCM.TAG, "onMessageReceived");
1717

1818
String pushId = remoteMessage.getData().get("push_id");
1919
String timestamp = remoteMessage.getData().get("time");

gcm/src/main/java/com/parse/gcm/ParseGCM.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public class ParseGCM {
3535
*/
3636
public static void register(@NonNull Context context) {
3737
//kicks off the background job
38-
PLog.v(TAG, "Scheduling job to register Parse GCM");
38+
PLog.d(TAG, "Scheduling job to register Parse GCM");
3939
FirebaseJobDispatcher dispatcher = new FirebaseJobDispatcher(new GooglePlayDriver(context.getApplicationContext()));
4040
Job job = ParseGCMJobService.createJob(dispatcher, gcmSenderFromManifest(context));
4141
dispatcher.mustSchedule(job);

gcm/src/main/java/com/parse/gcm/ParseGCMJobService.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ static Job createJob(FirebaseJobDispatcher dispatcher, String gcmSenderId) {
5353

5454
@Override
5555
public boolean onStartJob(final JobParameters job) {
56-
PLog.v(ParseGCM.TAG, "Updating GCM token");
56+
PLog.d(ParseGCM.TAG, "Updating GCM token");
5757

5858
Task.callInBackground(new Callable<Void>() {
5959
@Override
@@ -68,7 +68,7 @@ public Void call() throws Exception {
6868
//even though this is FCM, calling it gcm will work on the backend
6969
installation.setPushType("gcm");
7070
installation.save();
71-
PLog.v(ParseGCM.TAG, "GCM registration success");
71+
PLog.d(ParseGCM.TAG, "GCM registration success");
7272
} catch (Exception e) {
7373
PLog.e(ParseGCM.TAG, "GCM registration failed", e);
7474
jobFinished(job, true);

0 commit comments

Comments
 (0)