feat(forge): forge lint (foundry-rs#10405)

* add lint cmd, variable lints

* wip

* wip

* wip

* wip

* wip

* wip

* add keccak256 opt test

* wip

* wip

* wip

* wip

* fix div before mul

* update lint args

* wip

* update declare lints macro

* update with_severity

* configure linter

* wip

* update hash value

* fix read in source

* rayon

* reorder lint declarations

* clippy

* add placeholder for additional lints

* more placeholders

* wip

* wip

* refactor into sol linter

* impl Linter for SolidityLinter

* fmt

* wip

* wip

* refactor lints into SolLint enum

* update lint trait

* wip

* wip

* wip

* wip

* wip

* update lint

* update forge lint to use ProjectLinter

* wip

* include/exclude files from linting

* linter output display note

* configure with severity and description

* fmt

* implementing display

* wip

* wip

* implement display for linter output, clippy fixes

* add note to update colors

* update linter output display

* remove todos, clean up comments

* clean up display

* update med finding color

* add optional help message

* display help message

* simplify lint args, make severity configurable

* updating lints, update tests

* add tests for info patterns, fix regex

* remove function mixed case

* doc comments

* clippy

* fmt

* reorganize, crate level docs

* fix info lints

* Use Solar daignostics instead of `LinterOutput` (#6)

* use solar diagnostics, remove unneeded types

* update diagnostic emission

* clippy

* set track daignostics to false

* display help message

* set level according to severity

* update descriptions to be more concise

* removed LinterError from lint trait

* early pass + tests

* fix: fmt + clippy

* fix: fmt + clippy

* fix: fmt + clippy

* fix: fmt + clippy

* fix: feedback

* fix: feedback

* fix: regex

Co-authored-by: zerosnacks <95942363+zerosnacks@users.noreply.github.com>

* tests: cli integration

* fix: broken test

* fix: fmt

Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>

* style: naming

Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>

* style: fmt

Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>

* fix: use heck + individual lint macros + housekeeping

* fix: single session with parallel linting per file

* style: fix docs errors + typos

* docs: ref to deleted field

* fix: preprocessor regression + cargo.toml + default lint config tests

* test(forge): solar test runner (#2)

* style: clippy

* typo

Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>

* fix: housekeeping

* docs: linter docs for users + devs

* docs: style

* docs: style

* clone lint testdata with lf

* fix: out dir constructor

* update toml

* fix: merge conflicts

* fix: cargo.lock merge conflicts

* style: clippy

* style: whitespace

* fix: clippy

* Cargo.lock update to weekly task

* Preserve alloy patch placeholders

* Clippy

---------

Co-authored-by: 0xKitsune <0xkitsune@protonmail.com>
Co-authored-by: 0xKitsune <77890308+0xKitsune@users.noreply.github.com>
Co-authored-by: zerosnacks <95942363+zerosnacks@users.noreply.github.com>
Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
Co-authored-by: grandizzy <grandizzy.the.egg@gmail.com>
Co-authored-by: grandizzy <38490174+grandizzy@users.noreply.github.com>

Author: 5 people

.gitattributes

@@ -3,3 +3,4 @@ testdata/cheats/Vm.sol linguist-generated
 
 # See <https://git-scm.com/docs/gitattributes#_defining_a_custom_hunk_header>
 *.rs diff=rust
+crates/lint/testdata/* text eol=lf

Cargo.lock

@@ -23,6 +23,7 @@ members = [
     "crates/script-sequence/",
     "crates/macros/",
     "crates/test-utils/",
+    "crates/lint/",
 ]
 resolver = "2"
 
@@ -173,6 +174,7 @@ forge = { path = "crates/forge" }
 
 forge-doc = { path = "crates/doc" }
 forge-fmt = { path = "crates/fmt" }
+forge-lint = { path = "crates/lint" }
 forge-verify = { path = "crates/verify" }
 forge-script = { path = "crates/script" }
 forge-sol-macro-gen = { path = "crates/sol-macro-gen" }
@@ -200,7 +202,9 @@ foundry-block-explorers = { version = "0.17.0", default-features = false }
 foundry-compilers = { version = "0.16.1", default-features = false }
 foundry-fork-db = "0.14"
 solang-parser = { version = "=0.3.8", package = "foundry-solang-parser" }
+solar-ast = { version = "=0.1.3", default-features = false }
 solar-parse = { version = "=0.1.3", default-features = false }
+solar-interface = { version = "=0.1.3", default-features = false }
 solar-sema = { version = "=0.1.3", default-features = false }
 
 ## alloy
@@ -337,6 +341,7 @@ vergen = { version = "8", default-features = false }
 yansi = { version = "1.0", features = ["detect-tty", "detect-env"] }
 path-slash = "0.2"
 jiff = "0.2"
+heck = "0.5"
 
 ## Pinned dependencies. Enabled for the workspace in crates/test-utils.
 

Cargo.toml

@@ -1679,7 +1679,7 @@ mod tests {
     fn deser_to_type_tx() {
         let tx = r#"
         {
-            "EIP1559": { 
+            "EIP1559": {
                 "chainId": "0x7a69",
                 "nonce": "0x0",
                 "gas": "0x5209",

crates/anvil/core/src/eth/transaction/mod.rs

@@ -23,14 +23,15 @@ alloy-primitives = { workspace = true, features = ["serde"] }
 revm.workspace = true
 
 solar-parse.workspace = true
+solar-interface.workspace = true
 
 dirs.workspace = true
 dunce.workspace = true
 eyre.workspace = true
 figment = { workspace = true, features = ["toml", "env"] }
 glob = "0.3"
 globset = "0.4"
-heck = "0.5"
+heck.workspace = true
 itertools.workspace = true
 mesc.workspace = true
 number_prefix = "0.4"
@@ -46,6 +47,7 @@ toml_edit = "0.22"
 tracing.workspace = true
 walkdir.workspace = true
 yansi.workspace = true
+clap = { version = "4", features = ["derive"] }
 
 [target.'cfg(target_os = "windows")'.dependencies]
 path-slash = "0.2"