Skip to content

Commit 9d05683

Browse files
committed
Move shared params from mldsa specific module
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
1 parent 2765af6 commit 9d05683

File tree

3 files changed

+20
-20
lines changed

3 files changed

+20
-20
lines changed

cryptoki/src/mechanism/mldsa.rs renamed to cryptoki/src/mechanism/dsa.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
//! ML-DSA mechanism types
1+
//! ML-DSA and SLH-DSA mechanism parameters
22
33
use crate::mechanism::{Mechanism, MechanismType};
44

55
use cryptoki_sys::*;
66
use std::{convert::TryInto, marker::PhantomData, ptr::null_mut};
77

8-
/// The hedge type for ML-DSA signature
8+
/// The hedge type for ML-DSA and SLH-DSA signature
99
#[derive(Debug, Clone, Copy, PartialEq, Default)]
1010
pub enum HedgeType {
1111
/// Token may create either a hedged signature or a deterministic signature
@@ -33,7 +33,7 @@ impl From<HedgeType> for CK_ULONG {
3333
}
3434
}
3535

36-
/// The ML-DSA additional context for signatures
36+
/// The ML-DSA and SLH-DSA additional context for signatures
3737
///
3838
/// This structure wraps `CK_SIGN_ADDITIONAL_CONTEXT` structure.
3939
#[derive(Debug, Clone, Copy)]
@@ -44,7 +44,7 @@ pub struct SignAdditionalContext<'a> {
4444
}
4545

4646
impl SignAdditionalContext<'_> {
47-
/// Construct ML-DSA signature parameters.
47+
/// Construct ML-DSA and SLH-DSA signature parameters.
4848
///
4949
/// # Arguments
5050
///
@@ -94,7 +94,7 @@ impl SignAdditionalContext<'_> {
9494
}
9595
}
9696

97-
/// The ML-DSA additional context for signatures with hashing information
97+
/// The ML-DSA and SLH-DSA additional context for signatures with hashing information
9898
///
9999
/// This structure wraps `CK_HASH_SIGN_ADDITIONAL_CONTEXT` structure.
100100
#[derive(Debug, Clone, Copy)]
@@ -105,7 +105,7 @@ pub struct HashSignAdditionalContext<'a> {
105105
}
106106

107107
impl HashSignAdditionalContext<'_> {
108-
/// Construct HashML-DSA Signature parameters.
108+
/// Construct HashML-DSA or HashSLH-DSA Signature parameters.
109109
///
110110
/// # Arguments
111111
///

cryptoki/src/mechanism/mod.rs

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,13 @@
33
//! Data types for mechanisms
44
55
pub mod aead;
6+
pub mod dsa;
67
pub mod eddsa;
78
pub mod ekdf;
89
pub mod elliptic_curve;
910
pub mod hkdf;
1011
pub mod kbkdf;
1112
mod mechanism_info;
12-
pub mod mldsa;
1313
pub mod rsa;
1414
pub mod vendor_defined;
1515

@@ -1152,29 +1152,29 @@ pub enum Mechanism<'a> {
11521152
/// ML-DSA key pair generation mechanism
11531153
MlDsaKeyPairGen,
11541154
/// ML-DSA signature mechanism
1155-
MlDsa(mldsa::SignAdditionalContext<'a>),
1155+
MlDsa(dsa::SignAdditionalContext<'a>),
11561156
/// HashML-DSA signature mechanism
1157-
HashMlDsa(mldsa::HashSignAdditionalContext<'a>),
1157+
HashMlDsa(dsa::HashSignAdditionalContext<'a>),
11581158
/// HashML-DSA signature mechanism with SHA224
1159-
HashMlDsaSha224(mldsa::SignAdditionalContext<'a>),
1159+
HashMlDsaSha224(dsa::SignAdditionalContext<'a>),
11601160
/// HashML-DSA signature mechanism with SHA256
1161-
HashMlDsaSha256(mldsa::SignAdditionalContext<'a>),
1161+
HashMlDsaSha256(dsa::SignAdditionalContext<'a>),
11621162
/// HashML-DSA signature mechanism with SHA384
1163-
HashMlDsaSha384(mldsa::SignAdditionalContext<'a>),
1163+
HashMlDsaSha384(dsa::SignAdditionalContext<'a>),
11641164
/// HashML-DSA signature mechanism with SHA512
1165-
HashMlDsaSha512(mldsa::SignAdditionalContext<'a>),
1165+
HashMlDsaSha512(dsa::SignAdditionalContext<'a>),
11661166
/// HashML-DSA signature mechanism with SHA3-224
1167-
HashMlDsaSha3_224(mldsa::SignAdditionalContext<'a>),
1167+
HashMlDsaSha3_224(dsa::SignAdditionalContext<'a>),
11681168
/// HashML-DSA signature mechanism with SHA3-256
1169-
HashMlDsaSha3_256(mldsa::SignAdditionalContext<'a>),
1169+
HashMlDsaSha3_256(dsa::SignAdditionalContext<'a>),
11701170
/// HashML-DSA signature mechanism with SHA3-384
1171-
HashMlDsaSha3_384(mldsa::SignAdditionalContext<'a>),
1171+
HashMlDsaSha3_384(dsa::SignAdditionalContext<'a>),
11721172
/// HashML-DSA signature mechanism with SHA3-512
1173-
HashMlDsaSha3_512(mldsa::SignAdditionalContext<'a>),
1173+
HashMlDsaSha3_512(dsa::SignAdditionalContext<'a>),
11741174
/// HashML-DSA signature mechanism with SHAKE128
1175-
HashMlDsaShake128(mldsa::SignAdditionalContext<'a>),
1175+
HashMlDsaShake128(dsa::SignAdditionalContext<'a>),
11761176
/// HashML-DSA signature mechanism with SHAKE256
1177-
HashMlDsaShake256(mldsa::SignAdditionalContext<'a>),
1177+
HashMlDsaShake256(dsa::SignAdditionalContext<'a>),
11781178

11791179
/// Vendor defined mechanism
11801180
VendorDefined(VendorDefinedMechanism<'a>),

cryptoki/tests/ml_dsa.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ mod common;
55
use crate::common::{init_pins, USER_PIN};
66
use cryptoki::context::Function;
77
use cryptoki::error::{Error, RvError};
8-
use cryptoki::mechanism::mldsa::{HashSignAdditionalContext, HedgeType, SignAdditionalContext};
8+
use cryptoki::mechanism::dsa::{HashSignAdditionalContext, HedgeType, SignAdditionalContext};
99
use cryptoki::mechanism::{Mechanism, MechanismType};
1010
use cryptoki::object::{Attribute, AttributeType, MlDsaParameterSetType};
1111
use cryptoki::session::UserType;

0 commit comments

Comments
 (0)