Skip to content

Commit dca1f26

Browse files
author
Developer
committed
Enhanced to deliver version as a string to communicate version as major.minor.patch to web client 0.99+.
1 parent 32e4f2a commit dca1f26

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

BlocklyPropClient.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ def handle_connect(self):
229229
# read entered values and start server
230230
self.server_process = multiprocessing.Process(
231231
target=BlocklyServer.main,
232-
args=(int(self.port.get()), self.version, self.q))
232+
args=(int(self.port.get()), self.version, self.app_version, self.q))
233233

234234
self.server_process.start()
235235

BlocklyServer.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,12 @@
2121

2222
class BlocklyServer(object):
2323

24-
def __init__(self, version, queue):
24+
def __init__(self, version, app_version, queue):
2525
self.logger = logging.getLogger('blockly.server')
2626
self.logger.info('Creating server logger.')
2727

2828
self.version = version
29+
self.app_version = app_version
2930
self.queue = queue
3031

3132
# Find the path from which application was launched
@@ -47,9 +48,11 @@ def __init__(self, version, queue):
4748
def index(self):
4849
cherrypy.response.headers['Access-Control-Allow-Origin'] = '*'
4950

51+
# version supports pre-0.99 web clients, version_str supports v0.99+ web clients
5052
serverinfo = {
5153
"server": "BlocklyPropHTTP",
52-
"version": self.version
54+
"version": self.version,
55+
"version_str": self.app_version
5356
}
5457
self.queue.put((1, 'TRACE', 'Server poll received'))
5558
self.logger.debug('Server poll received')
@@ -125,7 +128,7 @@ def serial_socket(self):
125128
handler = cherrypy.request.ws_handler
126129

127130

128-
def main(port, version, queue):
131+
def main(port, version, app_version, queue):
129132
module_logger.info("Server starting")
130133
queue.put((10, 'INFO', 'Server starting'))
131134

@@ -137,7 +140,7 @@ def main(port, version, queue):
137140

138141
queue.put((10, 'INFO', 'Websocket configured'))
139142

140-
cherrypy.quickstart(BlocklyServer(version, queue), '/', config={'/serial.connect': {
143+
cherrypy.quickstart(BlocklyServer(version, app_version, queue), '/', config={'/serial.connect': {
141144
'tools.websocket.on': True,
142145
'tools.websocket.handler_cls': SerialSocket
143146
}})

0 commit comments

Comments
 (0)