refactor(net): remove unused enable_packet_filter and ban_duration from config #20146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Dec 6, 2025
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
reasonable, we dont need banning on this level really
mattsse
added
C-debt
shekhirin
pushed a commit
that referenced
this pull request
Dec 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed enable_packet_filter and ban_duration from Discv4Config and their builder methods. These fields were not used by the discv4 service: inbound packet filtering is always applied in receive_loop, and ban duration is managed at the peers manager layer, not in discv4. Updated defaults and tests accordingly.