Move the copies to the tests

Author: mroeschke

pandas/tests/base/test_fillna.py

@@ -44,6 +44,7 @@ def test_fillna_null(null_obj, index_or_series_obj):
     elif isinstance(obj, MultiIndex):
         pytest.skip(f"MultiIndex can't hold '{null_obj}'")
 
+    obj = obj.copy(deep=True)
     values = obj._values
     fill_value = values[0]
     expected = values.copy()

pandas/tests/base/test_unique.py

@@ -46,6 +46,7 @@ def test_unique_null(null_obj, index_or_series_obj, using_nan_is_na):
     ):
         pytest.skip("NaN is not a valid NA for this dtype.")
 
+    obj = obj.copy(deep=True)
     values = obj._values
     values[0:2] = null_obj
 
@@ -87,6 +88,7 @@ def test_nunique_null(null_obj, index_or_series_obj):
     elif isinstance(obj, pd.MultiIndex):
         pytest.skip(f"MultiIndex can't hold '{null_obj}'")
 
+    obj = obj.copy(deep=True)
     values = obj._values
     values[0:2] = null_obj
 

pandas/tests/base/test_value_counts.py

@@ -55,15 +55,15 @@ def test_value_counts(index_or_series_obj):
 @pytest.mark.filterwarnings(r"ignore:PeriodDtype\[B\] is deprecated:FutureWarning")
 def test_value_counts_null(null_obj, index_or_series_obj):
     orig = index_or_series_obj
-    obj = orig.copy()
 
-    if not allow_na_ops(obj):
+    if not allow_na_ops(orig):
         pytest.skip("type doesn't allow for NA operations")
-    elif len(obj) < 1:
+    elif len(orig) < 1:
         pytest.skip("Test doesn't make sense on empty data")
     elif isinstance(orig, MultiIndex):
         pytest.skip(f"MultiIndex can't hold '{null_obj}'")
 
+    obj = orig.copy(deep=True)
     values = obj._values
     values[0:2] = null_obj
 

pandas/tests/generic/test_to_xarray.py

@@ -31,7 +31,7 @@ def df(self):
         )
 
     def test_to_xarray_index_types(self, index_flat, df, request):
-        index = index_flat
+        index = index_flat.copy(deep=False)
         # MultiIndex is tested in test_to_xarray_with_multiindex
         if len(index) == 0:
             pytest.skip("Test doesn't make sense for empty index")
@@ -84,7 +84,7 @@ def test_to_xarray_with_multiindex(self, df, using_infer_string):
 class TestSeriesToXArray:
     def test_to_xarray_index_types(self, index_flat, request):
         # MultiIndex is tested in test_to_xarray_with_multiindex
-        index = index_flat
+        index = index_flat.copy(deep=False)
 
         ser = Series(range(len(index)), index=index, dtype="int64")
         ser.index.name = "foo"

pandas/tests/indexes/test_common.py

@@ -106,7 +106,7 @@ def test_to_flat_index(self, index_flat):
 
     def test_set_name_methods(self, index_flat):
         # MultiIndex tested separately
-        index = index_flat
+        index = index_flat.copy(deep=False)
         new_name = "This is the new name for this index"
 
         original_name = index.name
@@ -230,7 +230,7 @@ def test_unique(self, index_flat):
         if not index._can_hold_na:
             pytest.skip("Skip na-check if index cannot hold na")
 
-        vals = index._values[[0] * 5]
+        vals = index._values.copy()[[0] * 5]
         vals[0] = np.nan
 
         vals_unique = vals[:2]