move test comparing with python to test_find_replace.py

Author: jorisvandenbossche

pandas/tests/extension/test_arrow.py

@@ -1870,6 +1870,8 @@ def test_str_match(pat, case, na, exp):
 
 @pytest.mark.parametrize(
     "pat, case, na, exp",
+    # Note: keep cases in sync with
+    # pandas/tests/strings/test_find_replace.py::test_str_fullmatch_extra_cases
     [
         ["abc", False, None, [True, False, False, None]],
         ["Abc", True, None, [False, False, False, None]],
@@ -1884,19 +1886,11 @@ def test_str_match(pat, case, na, exp):
         ["Abc\\$", True, None, [False, False, False, None]],
     ],
 )
-class TestFullmatch:
-    def test_str_fullmatch(self, pat, case, na, exp):
-        ser = pd.Series(["abc", "abc$", "$abc", None], dtype=ArrowDtype(pa.string()))
-        result = ser.str.fullmatch(pat, case=case, na=na)
-        expected = pd.Series(exp, dtype=ArrowDtype(pa.bool_()))
-        tm.assert_series_equal(result, expected)
-
-    def test_str_fullmatch_against_python_fullmatch(self, pat, case, na, exp):
-        ser = pd.Series(["abc", "abc$", "$abc"], dtype=ArrowDtype(pa.string()))
-        ser2 = pd.Series(["abc", "abc$", "$abc"], dtype=str)
-        result = ser.str.fullmatch(pat, case=case, na=na)
-        result2 = ser2.str.fullmatch(pat, case=case, na=na).astype(result.dtype)
-        tm.assert_series_equal(result, result2)
+def test_str_fullmatch(pat, case, na, exp):
+    ser = pd.Series(["abc", "abc$", "$abc", None], dtype=ArrowDtype(pa.string()))
+    result = ser.str.fullmatch(pat, case=case, na=na)
+    expected = pd.Series(exp, dtype=ArrowDtype(pa.bool_()))
+    tm.assert_series_equal(result, expected)
 
 
 @pytest.mark.parametrize(

pandas/tests/strings/test_find_replace.py

@@ -1075,6 +1075,41 @@ def test_fullmatch_compiled_regex(any_string_dtype):
         values.str.fullmatch(re.compile("ab"), flags=re.IGNORECASE)
 
 
+@pytest.mark.parametrize(
+    "pat, case, na, exp",
+    # Note: keep cases in sync with
+    # pandas/tests/extension/test_arrow.py::test_str_fullmatch
+    [
+        ["abc", False, None, [True, False, False, None]],
+        ["Abc", True, None, [False, False, False, None]],
+        ["bc", True, None, [False, False, False, None]],
+        ["ab", False, None, [False, False, False, None]],
+        ["a[a-z]{2}", False, None, [True, False, False, None]],
+        ["A[a-z]{1}", True, None, [False, False, False, None]],
+        # GH Issue: #56652
+        ["abc$", False, None, [True, False, False, None]],
+        ["abc\\$", False, None, [False, True, False, None]],
+        ["Abc$", True, None, [False, False, False, None]],
+        ["Abc\\$", True, None, [False, False, False, None]],
+    ],
+)
+def test_str_fullmatch_extra_cases(any_string_dtype, pat, case, na, exp):
+    ser = Series(["abc", "abc$", "$abc", None], dtype=any_string_dtype)
+    result = ser.str.fullmatch(pat, case=case, na=na)
+
+    if any_string_dtype == "str":
+        # NaN propagates as False
+        exp[-1] = False
+        expected_dtype = bool
+    else:
+        expected_dtype = (
+            "object" if is_object_or_nan_string_dtype(any_string_dtype) else "boolean"
+        )
+        expected = Series([True, False, np.nan, False], dtype=expected_dtype)
+    expected = Series(exp, dtype=expected_dtype)
+    tm.assert_series_equal(result, expected)
+
+
 # --------------------------------------------------------------------------------------
 # str.findall
 # --------------------------------------------------------------------------------------