Skip to content

Commit 73d168b

Browse files
committed
Updated catch for str[python[ in test_add_frame
1 parent ad9614b commit 73d168b

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

pandas/tests/arrays/string_/test_string.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -278,11 +278,9 @@ def test_add_strings(dtype):
278278

279279
@pytest.mark.xfail(reason="GH-28527")
280280
def test_add_frame(request, dtype):
281-
if isinstance(dtype, "str[python]"):
282-
# This ONE dtype actually succeeds the test
283-
# We are manually failing it to maintain continuity
284-
mark = pytest.mark.xfail(reason="[XPASS(strict)] GH-28527")
285-
request.applymarker(mark)
281+
# "str[python]" actually safely adds but with the wrong dtype
282+
# result = <StringDtype(na_value=nan)>
283+
# expected = <StringDtype(storage='python', na_value=nan)>
286284
arr = pd.array(["a", "b", np.nan, np.nan], dtype=dtype)
287285
df = pd.DataFrame([["x", np.nan, "y", np.nan]])
288286
assert arr.__add__(df) is NotImplemented

0 commit comments

Comments
 (0)