TST(string dtype): Resolve xfail for interpolate

Author: rhshadrach

pandas/core/arrays/arrow/array.py

@@ -2160,7 +2160,7 @@ def interpolate(
         """
         # NB: we return type(self) even if copy=False
         if not self.dtype._is_numeric:
-            raise ValueError("Values must be numeric.")
+            raise TypeError(f"Cannot interpolate with {self.dtype} dtype")
 
         if (
             not pa_version_under13p0

pandas/tests/frame/methods/test_interpolate.py

@@ -64,11 +64,7 @@ def test_interpolate_inplace(self, frame_or_series, request):
         assert np.shares_memory(orig, obj.values)
         assert orig.squeeze()[1] == 1.5
 
-    # TODO(infer_string) raise proper TypeError in case of string dtype
-    @pytest.mark.xfail(
-        using_string_dtype(), reason="interpolate doesn't work for string"
-    )
-    def test_interp_basic(self):
+    def test_interp_basic(self, using_infer_string):
         df = DataFrame(
             {
                 "A": [1, 2, np.nan, 4],
@@ -77,7 +73,8 @@ def test_interp_basic(self):
                 "D": list("abcd"),
             }
         )
-        msg = "DataFrame cannot interpolate with object dtype"
+        dtype = "str" if using_infer_string else "object"
+        msg = f"[Cc]annot interpolate with {dtype} dtype"
         with pytest.raises(TypeError, match=msg):
             df.interpolate()
 
@@ -88,7 +85,8 @@ def test_interp_basic(self):
 
         # check we DID operate inplace
         assert np.shares_memory(df["C"]._values, cvalues)
-        assert np.shares_memory(df["D"]._values, dvalues)
+        if not using_infer_string:
+            assert np.shares_memory(df["D"]._values, dvalues)
 
     @pytest.mark.xfail(
         using_string_dtype(), reason="interpolate doesn't work for string"