Undo max/min rule from ruff

Author: mroeschke

pandas/core/_numba/kernels/min_max_.py

@@ -112,9 +112,11 @@ def grouped_min_max(
             continue
 
         if is_max:
-            output[lab] = max(val, output[lab])
+            if val > output[lab]:
+                output[lab] = val
         else:
-            output[lab] = min(val, output[lab])
+            if val < output[lab]:
+                output[lab] = val
 
     # Set labels that don't satisfy min_periods as np.nan
     for lab, count in enumerate(nobs):

pandas/core/dtypes/cast.py

@@ -683,7 +683,9 @@ def _maybe_promote(dtype: np.dtype, fill_value=np.nan):
 
         elif dtype.kind == "f":
             mst = np.min_scalar_type(fill_value)
-            dtype = max(mst, dtype)
+            if mst > dtype:
+                # e.g. mst is np.float64 and dtype is np.float32
+                dtype = mst
 
         elif dtype.kind == "c":
             mst = np.min_scalar_type(fill_value)
@@ -716,7 +718,9 @@ def _maybe_promote(dtype: np.dtype, fill_value=np.nan):
 
         elif dtype.kind == "c":
             mst = np.min_scalar_type(fill_value)
-            dtype = max(mst, dtype)
+            if mst > dtype:
+                # e.g. mst is np.complex128 and dtype is np.complex64
+                dtype = mst
 
     else:
         dtype = np.dtype(np.object_)

pandas/io/excel/_odfreader.py

@@ -142,7 +142,8 @@ def get_sheet_data(
                         empty_cells = 0
                         table_row.extend([value] * column_repeat)
 
-            max_row_len = max(max_row_len, len(table_row))
+            if max_row_len < len(table_row):
+                max_row_len = len(table_row)
 
             row_repeat = self._get_row_repeat(sheet_row)
             if len(table_row) == 0:

pandas/tests/arithmetic/test_numeric.py

@@ -274,7 +274,9 @@ def test_numeric_arr_rdiv_tdscalar(self, three_days, numeric_idx, box_with_array
         expected = TimedeltaIndex(["3 Days", "36 Hours"])
         if isinstance(three_days, np.timedelta64):
             dtype = three_days.dtype
-            dtype = max(dtype, np.dtype("m8[s]"))
+            if dtype < np.dtype("m8[s]"):
+                # i.e. resolution is lower -> use lowest supported resolution
+                dtype = np.dtype("m8[s]")
             expected = expected.astype(dtype)
         elif type(three_days) is timedelta:
             expected = expected.astype("m8[us]")

pyproject.toml

@@ -324,7 +324,8 @@ ignore = [
   "PT019",
   # The following rules may cause conflicts when used with the formatter:
   "ISC001",
-
+  # if-stmt-min-max
+  "PLR1730",
 
   ### TODO: Enable gradually
   # Useless statement