GH1432 Partial resolution for some TODOs #1492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmp0xff
reviewed
Nov 18, 2025
…r_non_unique, get_indexer_for, map, get_slice_bound (pandas-dev#1505) * type Index methods: putmask, asof, asof_locs, sort_values, get_indexer_non_unique, get_indexer_for, map, get_slice_bound * remove redundant `IntervalIndexer.get_indexer_non_unique` * slice_locs can return either `np.integer` or `int` * fix slice_locs test * Apply suggestions from code review Co-authored-by: Yi-Fan Wang <cmp0xff@users.noreply.github.com> * np.integer -> np.intp * test more mask types for `putmask` * Apply suggestions from code review Co-authored-by: Yi-Fan Wang <cmp0xff@users.noreply.github.com> * test asof with str --------- Co-authored-by: Yi-Fan Wang <cmp0xff@users.noreply.github.com>
cmp0xff
requested changes
Nov 30, 2025
Contributor
cmp0xff
left a comment
cmp0xff
left a comment
There was a problem hiding this comment.
Just one comment from the discussion.
fix: pandas-dev#1508 numpy arrays in tests
* GH1484 Upgrade ty * GH1484 Fix formatting * GH1484 Update PR
Co-authored-by: Yi-Fan Wang <cmp0xff@users.noreply.github.com>
… into gh1432_todos
cmp0xff
approved these changes
Dec 1, 2025
Contributor
cmp0xff
left a comment
cmp0xff
left a comment
There was a problem hiding this comment.
Thank you @loicdiridollou !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs intimestamps.pyi,timedeltas.pyiandorc.pyi#1432assert_type()to assert the type of any return valueResolution for: