Iterable -> Iterable[Any], extra test cases

Author: MarcoGorelli

pandas-stubs/core/frame.pyi

@@ -1784,7 +1784,7 @@ class DataFrame(NDFrame, OpsMixin, _GetItemHack):
         copy: _bool = True,
     ) -> Self: ...
     def isin(
-        self, values: Iterable | DataFrame | Mapping[Hashable, Iterable]
+        self, values: Iterable[Any] | Mapping[Hashable, Iterable[Any]] | DataFrame
     ) -> Self: ...
     @property
     def plot(self) -> PlotAccessor: ...

pandas-stubs/core/indexes/base.pyi

@@ -554,7 +554,9 @@ class Index(IndexOpsMixin[S1], ElementOpsMixin[S1]):
     @final
     def get_indexer_for(self, target, **kwargs: Any): ...
     def map(self, mapper, na_action=...) -> Index: ...
-    def isin(self, values: Iterable, level: Level | None = None) -> np_1darray_bool: ...
+    def isin(
+        self, values: Iterable[Any], level: Level | None = None
+    ) -> np_1darray_bool: ...
     def slice_indexer(
         self,
         start: Label | None = None,

pandas-stubs/core/series.pyi

@@ -1302,7 +1302,7 @@ class Series(IndexOpsMixin[S1], ElementOpsMixin[S1], NDFrame):
         show_counts: bool | None = ...,
     ) -> None: ...
     def memory_usage(self, index: _bool = True, deep: _bool = False) -> int: ...
-    def isin(self, values: Iterable) -> Series[_bool]: ...
+    def isin(self, values: Iterable[Any]) -> Series[_bool]: ...
     def between(
         self,
         left: Scalar | ListLikeU,

tests/indexes/test_indexes.py

@@ -60,6 +60,7 @@ def test_index_isin() -> None:
     check(assert_type(ind.isin({2, 4}), np_1darray_bool), np_1darray_bool)
     check(assert_type(ind.isin(pd.Series([2, 4])), np_1darray_bool), np_1darray_bool)
     check(assert_type(ind.isin(pd.Index([2, 4])), np_1darray_bool), np_1darray_bool)
+    check(assert_type(ind.isin(iter([2, "4"])), np_1darray_bool), np_1darray_bool)
 
 
 def test_index_astype() -> None:

tests/series/test_series.py

@@ -1618,6 +1618,7 @@ def test_series_isin() -> None:
         assert_type(s.isin(pd.Series([3, 4])), "pd.Series[bool]"), pd.Series, np.bool_
     )
     check(assert_type(s.isin(pd.Index([3, 4])), "pd.Series[bool]"), pd.Series, np.bool_)
+    check(assert_type(s.isin(iter([3, "4"])), "pd.Series[bool]"), pd.Series, np.bool_)
 
 
 def test_series_index_isin() -> None:

tests/test_frame.py

@@ -2,6 +2,7 @@
 
 from collections import (
     OrderedDict,
+    UserDict,
     UserList,
     defaultdict,
     deque,
@@ -2948,6 +2949,10 @@ def test_frame_isin() -> None:
     check(assert_type(df.isin(pd.Index([1, 3, 5])), pd.DataFrame), pd.DataFrame)
     check(assert_type(df.isin(df), pd.DataFrame), pd.DataFrame)
     check(assert_type(df.isin({"x": [1, 2]}), pd.DataFrame), pd.DataFrame)
+    check(
+        assert_type(df.isin(UserDict({"x": iter([1, "2"])})), pd.DataFrame),
+        pd.DataFrame,
+    )
 
 
 def test_frame_getitem_isin() -> None: