Merge pull request #2 from pajaydev/bug-fix

Added support to seperator and assignment

Author: pajaydev

README.md

@@ -1,4 +1,4 @@
-# make-string [![Build Status](https://travis-ci.org/ajay2507/make-string.svg?branch=master)](https://travis-ci.org/ajay2507/make-string)
+# make-string [![Build Status](https://travis-ci.org/pajaydev/make-string.svg?branch=master)](https://travis-ci.org/pajaydev/make-string)
 
 make-string converts all data types to string as JSON.toString. 
 
@@ -14,7 +14,7 @@ const makeString = require('make-string');
 makeString(25); // '25'
 ```
 ## Why? ##
-I need to convert the object to string in configurable way like removing curly braces, with single quote, etc. So I created this module. If you face any issues with this module, Free feel to create the issues https://github.com/ajay2507/make-string/issues.
+I need to convert the object to string in configurable way like removing curly braces, with single quote, etc. So I created this module. If you face any issues with this module, Free feel to create the issues [here](https://github.com/pajaydev/make-string/issues).
 
 ## options ##
 Options can be passed as optional second param to makeString to configure few things.
@@ -34,4 +34,5 @@ makeString({package:"make-string"}); // '{"package":"make-string"}'
 makeString({package:"make-string"}, {braces: 'false'}); // '"package":"make-string"'
 makeString({package:"make-string"}, {assignment: '='}); // '{"package"="make-string"}'
 makeString({package:"make-string"}, {assignment: '=', quotes:'no'}); // '{package=make-string}'
+makeString({package:"make-string",author:"Ajay"}, {assignment: '=', quotes:'no', seperator:'&'}); // '{package=make-string&author=ajay}'
 ```

index.js

@@ -39,14 +39,11 @@ const createString = (value, option) => {
     if (isObject(value)) {
         option.seperator = option.seperator || ',';
         option.assignment = option.assignment || ':';
-        return option.braces === "true" ? '{' + iterateObj(value, option) + '}' : '' + iterateObj(value, option) + '';
+        const createObjString = iterateObj(value, option).join(option.seperator);
+        return option.braces === "true" ? '{' + createObjString + '}' : '' + createObjString + '';
     };
 
-
-
     return option.quotes === 'double' ? "" : '';
-
-
 }
 
 const iterateObj = (value, option) => {

package.json

@@ -1,6 +1,6 @@
 {
   "name": "make-string",
-  "version": "1.0.0",
+  "version": "1.0.3",
   "description": "convert all data types to string in configurable way",
   "main": "index.js",
   "scripts": {
@@ -18,5 +18,9 @@
     "toString",
     "JSON.toString",
     "makeString"
-  ]
+  ],
+  "repository": {
+    "type": "git",
+    "url": "https://github.com/pajaydev/make-string"
+  }
 }

test.js

@@ -100,6 +100,16 @@ describe("test toString method", () => {
         expect(str).to.equal('"name"="Ajay","city"="san jose"');
     });
 
+    it("test Object to string without braces and different seperator", () => {
+        const sampleObject = {
+            name: "Ajay",
+            city: "san jose"
+        }
+        const str = makeString(sampleObject, { braces: 'false', assignment: '=', seperator: '&', quotes: 'no' });
+        expect(str).to.be.a('string');
+        expect(str).to.equal('name=Ajay&city=san jose');
+    });
+
     it("test Object to string with and without quotes", () => {
         const sampleObject = {
             name: "Ajay",