[ereport-types] less ugly Display impl for EreportId
#9401
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Display` impl for `EreportId` was _supposed_ to format the ereport
ID as `{uuid}:{ena}`. Unfortunately, I mixed up which of the `Debug` and
`Display` impls for `TypedUuid` was the one that included the type tag,
so currently, it looks like this instead:
``` acb6b01f-5a41-46e2-81bd-2a908051acb3 (ereporter_restart):0x2 ```
which, IMO, looks Kinda Bad.
This branch changes it slightly to use the `Display` impl for the
`TypedUuid` so that there's no unslightly ` (ereporter_restart)`
included in the output. I've also formatted the underlying u64 from the
`Ena` so that it doesn't have an `0x` prefix, since the UUID makes it
pretty obvious that the whole string is hex.
Now it should look more like this:
``` acb6b01f-5a41-46e2-81bd-2a908051acb3:2 ```
Which, IMO, is much nicer.
sunshowers
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Displayimpl forEreportIdwas supposed to format the ereport ID as{uuid}:{ena}. Unfortunately, I mixed up which of theDebugandDisplayimpls forTypedUuidwas the one that included the type tag, so currently, it looks like this instead:which, IMO, looks Kinda Bad.
This branch changes it slightly to use the
Displayimpl for theTypedUuidso that there's no unslightly(ereporter_restart)included in the output. I've also formatted the underlying u64 from the
Enaso that it doesn't have an0xprefix, since the UUID makes itpretty obvious that the whole string is hex.
Now it should look more like this:
Which, IMO, is much nicer.