From f12eddf81a8f737e3043817a1e5377dbf097cdce Mon Sep 17 00:00:00 2001 From: Charlie Park Date: Mon, 25 Aug 2025 16:22:45 -0400 Subject: [PATCH 1/2] Prevent event bubbling on copy-to-clipboard clicks --- app/ui/lib/CopyToClipboard.tsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/ui/lib/CopyToClipboard.tsx b/app/ui/lib/CopyToClipboard.tsx index f00b2523a..0b865b8a0 100644 --- a/app/ui/lib/CopyToClipboard.tsx +++ b/app/ui/lib/CopyToClipboard.tsx @@ -35,7 +35,9 @@ export const CopyToClipboard = ({ useTimeout(() => setHasCopied(false), hasCopied ? 2000 : null) - const handleCopy = () => { + const handleCopy = (event: React.MouseEvent) => { + event.preventDefault() + event.stopPropagation() window.navigator.clipboard.writeText(text).then(() => { setHasCopied(true) }) From 284f82775275b602a1c00aeed1acfd2e6fa0a42c Mon Sep 17 00:00:00 2001 From: Charlie Park Date: Mon, 25 Aug 2025 17:37:19 -0400 Subject: [PATCH 2/2] only needs stopPropagation --- app/ui/lib/CopyToClipboard.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/app/ui/lib/CopyToClipboard.tsx b/app/ui/lib/CopyToClipboard.tsx index 0b865b8a0..733084276 100644 --- a/app/ui/lib/CopyToClipboard.tsx +++ b/app/ui/lib/CopyToClipboard.tsx @@ -36,7 +36,6 @@ export const CopyToClipboard = ({ useTimeout(() => setHasCopied(false), hasCopied ? 2000 : null) const handleCopy = (event: React.MouseEvent) => { - event.preventDefault() event.stopPropagation() window.navigator.clipboard.writeText(text).then(() => { setHasCopied(true)