fix: fix some antipatterns

Author: dev-737

scripts/syncEmojis.js

@@ -132,7 +132,7 @@ async function updateEmojiJson(emojis) {
 
   await Bun.write(jsonFile, JSON.stringify(updatedEmojiSet, null, 2));
   newSpinner.stop(
-    orangeText('ⓘ ') + `Added ${emojis.length} emojis with new emoji IDs to emojis.json file.`,
+    `${orangeText('ⓘ')} Added ${emojis.length} emoji(s) with new emoji ID(s) to emojis.json file.`,
   );
 }
 

scripts/utils.js

@@ -60,7 +60,7 @@ export class Spinner {
       const text = `${greyText(frame)} ${this.message}`.slice(0, maxTextLength);
 
       // Clear the current line
-      process.stdout.write('\r\x1B[K' + text);
+      process.stdout.write(`\r\x1B[K${text}`);
 
       this.lastLineLength = text.length;
       this.frameIndex = (this.frameIndex + 1) % this.frames.length;
@@ -73,10 +73,10 @@ export class Spinner {
     this.isSpinning = false;
 
     // Clear the spinner line
-    process.stdout.write('\r' + ' '.repeat(this.lastLineLength) + '\r');
+    process.stdout.write(`\r${' '.repeat(this.lastLineLength)}\r`);
 
     if (message) {
-      process.stdout.write(message + '\n');
+      process.stdout.write(`${message}\n`);
     }
 
     process.stdout.write('\x1B[?25h'); // Show cursor

src/commands/Main/connection/edit.ts

@@ -136,7 +136,8 @@ export default class ConnectionEditSubcommand extends BaseCommand {
 
       if (fetchedInvite?.guild?.id !== interaction.guildId) {
         await interaction.followUp({
-          content: t('connection.inviteInvalid', locale, {
+          // FIXME: remove ts
+          content: t('connection.setInviteError', locale, {
             emoji: getEmoji('x_icon', interaction.client),
           }),
           flags: ['Ephemeral'],

src/events/interactionCreate.ts

@@ -111,7 +111,7 @@ export default class InteractionCreate extends BaseEventListener<'interactionCre
     const { command } = resolveCommand(interaction);
     if (!command) return;
 
-    if (!this.validateCommandAccess(command, interaction)) return;
+    if (command.staffOnly && !checkIfStaff(interaction.user.id)) return;
 
     if (interaction.isAutocomplete()) {
       await this.handleAutocomplete(command, interaction);
@@ -121,16 +121,6 @@ export default class InteractionCreate extends BaseEventListener<'interactionCre
     await executeCommand(interaction, command);
   }
 
-  private validateCommandAccess(
-    command: BaseCommand | undefined,
-    interaction: Interaction | ContextMenuCommandInteraction,
-  ) {
-    if (command?.staffOnly && !checkIfStaff(interaction.user.id)) {
-      return false;
-    }
-    return true;
-  }
-
   private async handleAutocomplete(
     command: BaseCommand | undefined,
     interaction: AutocompleteInteraction,

src/managers/ConnectionManager.ts

@@ -56,7 +56,7 @@ export default class ConnectionManager {
 
   // Public methods
   async fetchHub() {
-    return this.hubService.fetchHub(this.hubId);
+    return await this.hubService.fetchHub(this.hubId);
   }
 
   async pause(): Promise<void> {
@@ -117,11 +117,7 @@ export default class ConnectionManager {
       where: { id: this.connection.id },
       data,
     });
-    await this.updateCache();
-  }
-
-  private async updateCache(): Promise<void> {
-    cacheHubConnection(this.connection);
+    await cacheHubConnection(this.connection);
   }
 
   private async clearCache(): Promise<void> {

src/managers/HubConnectionsManager.ts

@@ -70,7 +70,7 @@ export default class HubConnectionsManager {
     }
 
     const connection = await db.connection.create({ data });
-    await this.cacheConnection(connection);
+    await cacheHubConnection(connection);
     return new ConnectionManager(connection);
   }
 
@@ -85,7 +85,7 @@ export default class HubConnectionsManager {
   }
 
   async setConnection(connection: Connection): Promise<ConnectionManager> {
-    await this.cacheConnection(connection);
+    await cacheHubConnection(connection);
     return new ConnectionManager(connection);
   }
 
@@ -148,10 +148,6 @@ export default class HubConnectionsManager {
     Logger.debug(`Cached ${connections.length} connections for hub ${this.hub.id}`);
   }
 
-  private async cacheConnection(connection: Connection): Promise<void> {
-    cacheHubConnection(connection);
-  }
-
   private createManagersFromConnections(connections: Connection[]): ConnectionManager[] {
     return connections.map((conn) => new ConnectionManager(conn));
   }