Moving regex from utils to its own namespace

zimmerle · zimmerle · commit 8e62341ce610 · 2019-02-05T15:24:34.000-03:00
diff --git a/headers/modsecurity/anchored_set_variable.h b/headers/modsecurity/anchored_set_variable.h
@@ -38,7 +38,7 @@
 
 namespace modsecurity {
 class Transaction;
-namespace Utils {
+namespace regex {
 class Regex;
 }
 namespace Variables {
@@ -91,10 +91,10 @@ class AnchoredSetVariable : public std::unordered_multimap<std::string,
     void resolve(const std::string &key,
         std::vector<const VariableValue *> *l);
 
-    void resolveRegularExpression(Utils::Regex *r,
+    void resolveRegularExpression(regex::Regex *r,
         std::vector<const VariableValue *> *l);
 
-    void resolveRegularExpression(Utils::Regex *r,
+    void resolveRegularExpression(regex::Regex *r,
         std::vector<const VariableValue *> *l,
         Variables::KeyExclusions &ke);
 
diff --git a/src/Makefile.am b/src/Makefile.am
@@ -239,13 +239,17 @@ UTILS = \
 	utils/md5.cc \
 	utils/msc_tree.cc \
 	utils/random.cc \
-	utils/regex.cc \
 	utils/sha1.cc \
 	utils/string.cc \
 	utils/system.cc \
 	utils/shared_files.cc
 
 
+REGEX = \
+	regex/regex.cc \
+	regex/backend/pcre.cc
+
+
 COLLECTION = \
 	collection/collections.cc \
 	collection/backend/in_memory-per_process.cc \
@@ -287,6 +291,7 @@ libmodsecurity_la_SOURCES = \
 	${COLLECTION} \
 	${OPERATORS} \
 	${UTILS} \
+	${REGEX} \
 	${VARIABLES}
 
 
diff --git a/src/anchored_set_variable.cc b/src/anchored_set_variable.cc
@@ -22,7 +22,7 @@
 #include "modsecurity/anchored_set_variable.h"
 #include "modsecurity/modsecurity.h"
 #include "modsecurity/transaction.h"
-#include "src/utils/regex.h"
+#include "src/regex/regex.h"
 #include "src/variables/variable.h"
 
 namespace modsecurity {
@@ -124,10 +124,10 @@ std::unique_ptr<std::string> AnchoredSetVariable::resolveFirst(
 }
 
 
-void AnchoredSetVariable::resolveRegularExpression(Utils::Regex *r,
+void AnchoredSetVariable::resolveRegularExpression(regex::Regex *r,
     std::vector<const VariableValue *> *l) {
     for (const auto& x : *this) {
-        int ret = Utils::regex_search(x.first, *r);
+        int ret = regex::regex_search(x.first, *r);
         if (ret <= 0) {
             continue;
         }
@@ -136,11 +136,11 @@ void AnchoredSetVariable::resolveRegularExpression(Utils::Regex *r,
 }
 
 
-void AnchoredSetVariable::resolveRegularExpression(Utils::Regex *r,
+void AnchoredSetVariable::resolveRegularExpression(regex::Regex *r,
     std::vector<const VariableValue *> *l,
     Variables::KeyExclusions &ke) {
     for (const auto& x : *this) {
-        int ret = Utils::regex_search(x.first, *r);
+        int ret = regex::regex_search(x.first, *r);
         if (ret <= 0) {
             continue;
         }
diff --git a/src/anchored_variable.cc b/src/anchored_variable.cc
@@ -22,7 +22,7 @@
 #include "../headers/modsecurity/anchored_variable.h"
 #include "modsecurity/modsecurity.h"
 #include "modsecurity/transaction.h"
-#include "src/utils/regex.h"
+#include "src/regex/regex.h"
 
 namespace modsecurity {
 
diff --git a/src/audit_log/audit_log.cc b/src/audit_log/audit_log.cc
@@ -26,7 +26,7 @@
 #include "src/audit_log/writer/parallel.h"
 #include "src/audit_log/writer/serial.h"
 #include "src/audit_log/writer/writer.h"
-#include "src/utils/regex.h"
+#include "src/regex/regex.h"
 
 #define PARTS_CONSTAINS(a, c) \
     if (new_parts.find(toupper(a)) != std::string::npos \
@@ -279,8 +279,8 @@ bool AuditLog::isRelevant(int status) {
         return true;
     }
 
-    return Utils::regex_search(sstatus,
-        Utils::Regex(m_relevant)) != 0;
+    return regex::regex_search(sstatus,
+        regex::Regex(m_relevant)) != 0;
 }
 
 
diff --git a/src/collection/backend/in_memory-per_process.cc b/src/collection/backend/in_memory-per_process.cc
@@ -27,7 +27,7 @@
 #include <pthread.h>
 
 #include "modsecurity/variable_value.h"
-#include "src/utils/regex.h"
+#include "src/regex/regex.h"
 #include "src/utils/string.h"
 
 
@@ -134,7 +134,7 @@ void InMemoryPerProcess::resolveRegularExpression(const std::string& var,
     //std::string name = std::string(var, var.find(":") + 2,
     //    var.size() - var.find(":") - 3);
     //size_t keySize = col.size();
-    Utils::Regex r(var);
+    regex::Regex r(var);
 
     for (const auto& x : *this) {
         //if (x.first.size() <= keySize + 1) {
@@ -148,7 +148,7 @@ void InMemoryPerProcess::resolveRegularExpression(const std::string& var,
         //}
         //std::string content = std::string(x.first, keySize + 1,
          //                                 x.first.size() - keySize - 1);
-        int ret = Utils::regex_search(x.first, r);
+        int ret = regex::regex_search(x.first, r);
         if (ret <= 0) {
             continue;
         }
diff --git a/src/collection/backend/lmdb.cc b/src/collection/backend/lmdb.cc
@@ -23,7 +23,7 @@
 #include <memory>
 
 #include "modsecurity/variable_value.h"
-#include "src/utils/regex.h"
+#include "src/regex/regex.h"
 #include "src/variables/variable.h"
 
 #undef LMDB_STDOUT_COUT
@@ -538,7 +538,7 @@ void LMDB::resolveRegularExpression(const std::string& var,
     MDB_cursor *cursor;
     size_t pos;
 
-    Utils::Regex r(var);
+    regex::Regex r = regex::Regex(var);
 
     rc = mdb_txn_begin(m_env, NULL, 0, &txn);
     lmdb_debug(rc, "txn", "resolveRegularExpression");
@@ -560,7 +560,7 @@ void LMDB::resolveRegularExpression(const std::string& var,
 
     while ((rc = mdb_cursor_get(cursor, &key, &data, MDB_NEXT)) == 0) {
         char *a = reinterpret_cast<char *>(key.mv_data);
-        int ret = Utils::regex_search(a, r);
+        int ret = regex::regex_search(a, r);
         if (ret <= 0) {
             continue;
         }
diff --git a/src/modsecurity.cc b/src/modsecurity.cc
@@ -38,7 +38,7 @@
 #include "src/collection/backend/in_memory-per_process.h"
 #include "src/collection/backend/lmdb.h"
 #include "src/unique_id.h"
-#include "src/utils/regex.h"
+#include "src/regex/regex.h"
 #include "src/utils/geo_lookup.h"
 #include "src/actions/transformations/transformation.h"
 
@@ -219,18 +219,18 @@ void ModSecurity::serverLog(void *data, std::shared_ptr<RuleMessage> rm) {
 int ModSecurity::processContentOffset(const char *content, size_t len,
     const char *matchString, std::string *json, const char **err) {
 #ifdef WITH_YAJL
-    Utils::Regex variables("v([0-9]+),([0-9]+)");
-    Utils::Regex operators("o([0-9]+),([0-9]+)");
-    Utils::Regex transformations("t:(?:(?!t:).)+");
+    regex::Regex variables("v([0-9]+),([0-9]+)");
+    regex::Regex operators("o([0-9]+),([0-9]+)");
+    regex::Regex transformations("t:(?:(?!t:).)+");
     yajl_gen g;
     std::string varValue;
     std::string opValue;
     const unsigned char *buf;
     size_t jsonSize;
 
-    std::list<Utils::SMatch> vars = variables.searchAll(matchString);
-    std::list<Utils::SMatch> ops = operators.searchAll(matchString);
-    std::list<Utils::SMatch> trans = transformations.searchAll(matchString);
+    std::list<regex::SMatch> vars = variables.searchAll(matchString);
+    std::list<regex::SMatch> ops = operators.searchAll(matchString);
+    std::list<regex::SMatch> trans = transformations.searchAll(matchString);
 
     g = yajl_gen_alloc(NULL);
     if (g == NULL) {
diff --git a/src/operators/rx.h b/src/operators/rx.h
@@ -22,13 +22,13 @@
 #include <utility>
 
 #include "src/operators/operator.h"
-#include "src/utils/regex.h"
+#include "src/regex/regex.h"
 
 
 namespace modsecurity {
-using Utils::SMatch;
-using Utils::regex_search;
-using Utils::Regex;
+using regex::SMatch;
+using regex::regex_search;
+using regex::Regex;
 
 namespace operators {
 
diff --git a/src/operators/verify_cpf.h b/src/operators/verify_cpf.h
@@ -21,13 +21,13 @@
 #include <utility>
 
 #include "src/operators/operator.h"
-#include "src/utils/regex.h"
+#include "src/regex/regex.h"
 
 
 namespace modsecurity {
-using Utils::SMatch;
-using Utils::regex_search;
-using Utils::Regex;
+using regex::SMatch;
+using regex::regex_search;
+using regex::Regex;
 
 namespace operators {
 
diff --git a/src/operators/verify_ssn.h b/src/operators/verify_ssn.h
@@ -21,13 +21,13 @@
 #include <utility>
 
 #include "src/operators/operator.h"
-#include "src/utils/regex.h"
+#include "src/regex/regex.h"
 
 
 namespace modsecurity {
-using Utils::SMatch;
-using Utils::regex_search;
-using Utils::Regex;
+using regex::SMatch;
+using regex::regex_search;
+using regex::Regex;
 
 namespace operators {
 
diff --git a/src/regex/backend/pcre.cc b/src/regex/backend/pcre.cc
@@ -0,0 +1,35 @@
+/*
+ * ModSecurity, http://www.modsecurity.org/
+ * Copyright (c) 2015 Trustwave Holdings, Inc. (http://www.trustwave.com/)
+ *
+ * You may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * If any of the files related to licensing are missing or if you have any
+ * other questions related to licensing please contact Trustwave Holdings, Inc.
+ * directly using the email address security@modsecurity.org.
+ *
+ */
+
+#include <pcre.h>
+
+#include <iostream>
+#include <fstream>
+#include <string>
+#include <list>
+
+#ifndef SRC_REGEX_BACKEND_PCRE_H_
+#define SRC_REGEX_BACKEND_PCRE_H_
+
+namespace modsecurity {
+namespace regex {
+
+
+
+}  // namespace regex
+}  // namespace modsecurity
+
+
+#endif  // SRC_REGEX_BACKEND_PCRE_H_
diff --git a/src/regex/backend/pcre.h b/src/regex/backend/pcre.h
@@ -0,0 +1,35 @@
+/*
+ * ModSecurity, http://www.modsecurity.org/
+ * Copyright (c) 2015 Trustwave Holdings, Inc. (http://www.trustwave.com/)
+ *
+ * You may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * If any of the files related to licensing are missing or if you have any
+ * other questions related to licensing please contact Trustwave Holdings, Inc.
+ * directly using the email address security@modsecurity.org.
+ *
+ */
+
+#include <pcre.h>
+
+#include <iostream>
+#include <fstream>
+#include <string>
+#include <list>
+
+#ifndef SRC_REGEX_BACKEND_PCRE_H_
+#define SRC_REGEX_BACKEND_PCRE_H_
+
+namespace modsecurity {
+namespace regex {
+
+
+
+}  // namespace regex
+}  // namespace modsecurity
+
+
+#endif  // SRC_REGEX_BACKEND_PCRE_H_
diff --git a/src/regex/regex.cc b/src/regex/regex.cc
@@ -13,7 +13,7 @@
  *
  */
 
-#include "src/utils/regex.h"
+#include "src/regex/regex.h"
 
 #include <pcre.h>
 #include <sys/socket.h>
@@ -35,7 +35,7 @@
 #endif
 
 namespace modsecurity {
-namespace Utils {
+namespace regex {
 
 
 Regex::Regex(const std::string& pattern_)
@@ -119,5 +119,5 @@ int Regex::search(const std::string& s) const {
         s.size(), 0, 0, ovector, OVECCOUNT) > 0;
 }
 
-}  // namespace Utils
+}  // namespace regex
 }  // namespace modsecurity
diff --git a/src/regex/regex.cc.orig b/src/regex/regex.cc.orig
diff --git a/src/regex/regex.h b/src/regex/regex.h
@@ -20,12 +20,13 @@
 #include <string>
 #include <list>
 
-#ifndef SRC_UTILS_REGEX_H_
-#define SRC_UTILS_REGEX_H_
+#ifndef SRC_REGEX_REGEX_H_
+#define SRC_REGEX_REGEX_H_
 
 
 namespace modsecurity {
-namespace Utils {
+namespace regex {
+
 
 #define OVECCOUNT 30
 
@@ -78,7 +79,7 @@ static inline int regex_search(const std::string& s, const Regex& regex) {
 }
 
 
-}  // namespace Utils
+}  // namespace regex
 }  // namespace modsecurity
 
-#endif  // SRC_UTILS_REGEX_H_
+#endif  // SRC_REGEX_REGEX_H_
diff --git a/src/regex/regex.h.orig b/src/regex/regex.h.orig
diff --git a/src/variables/rule.h b/src/variables/rule.h
diff --git a/src/variables/variable.h b/src/variables/variable.h
diff --git a/test/regression/custom_debug_log.cc b/test/regression/custom_debug_log.cc
diff --git a/test/regression/regression.cc b/test/regression/regression.cc
diff --git a/test/unit/unit_test.cc b/test/unit/unit_test.cc
