Removed unused suppresion and avoid copy of logPath

eduar-hte · eduar-hte · commit 7a9c0ab15fcb · 2024-04-28T14:56:37.000-03:00
diff --git a/src/audit_log/writer/parallel.cc b/src/audit_log/writer/parallel.cc
@@ -118,7 +118,7 @@ bool Parallel::write(Transaction *transaction, int parts, std::string *error) {
         log = transaction->toOldAuditLogFormat(parts, "-" + boundary + "--");
     }
 
-    std::string logPath = m_audit->m_storage_dir;
+    const auto &logPath = m_audit->m_storage_dir;
     fileName = logPath + fileName + "-" + *transaction->m_id.get();
 
     if (logPath.empty()) {
diff --git a/test/cppcheck_suppressions.txt b/test/cppcheck_suppressions.txt
@@ -33,7 +33,6 @@ shiftNegative:src/utils/msc_tree.cc
 useInitializationList:src/utils/shared_files.h:87
 duplicateBranch:src/audit_log/audit_log.cc:226
 unreadVariable:src/request_body_processor/multipart.cc:435
-stlcstrParam:src/audit_log/writer/parallel.cc:145
 syntaxError:src/transaction.cc:62
 noConstructor:src/variables/variable.h:152
 rethrowNoCurrentException:headers/modsecurity/transaction.h:313

Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,7 @@ bool Parallel::write(Transaction transaction, int parts, std::string error) {`
`118`	`118`	`log = transaction->toOldAuditLogFormat(parts, "-" + boundary + "--");`
`119`	`119`	`}`
`120`	`120`
`121`		`- std::string logPath = m_audit->m_storage_dir;`
	`121`	`+ const auto &logPath = m_audit->m_storage_dir;`
`122`	`122`	`fileName = logPath + fileName + "-" + *transaction->m_id.get();`
`123`	`123`
`124`	`124`	`if (logPath.empty()) {`