Change from using rand() to thread-safe ap_random_pick.

bostrt · Felipe Zimmerle · commit 4f55b5d1a7ef · 2017-05-08T21:19:23.000-03:00
diff --git a/apache2/modsecurity.c b/apache2/modsecurity.c
@@ -237,7 +237,7 @@ static void modsecurity_persist_data(modsec_rec *msr) {
     }
 
     /* Remove stale collections. */
-    if (rand() < RAND_MAX/100) {
+    if (ap_random_pick(0, RAND_MAX) < RAND_MAX/100) {
         arr = apr_table_elts(msr->collections);
         te = (apr_table_entry_t *)arr->elts;
         for (i = 0; i < arr->nelts; i++) {

Original file line number	Diff line number	Diff line change
`@@ -237,7 +237,7 @@ static void modsecurity_persist_data(modsec_rec *msr) {`
`237`	`237`	`}`
`238`	`238`
`239`	`239`	`/* Remove stale collections. */`
`240`		`- if (rand() < RAND_MAX/100) {`
	`240`	`+ if (ap_random_pick(0, RAND_MAX) < RAND_MAX/100) {`
`241`	`241`	`arr = apr_table_elts(msr->collections);`
`242`	`242`	`te = (apr_table_entry_t *)arr->elts;`
`243`	`243`	`for (i = 0; i < arr->nelts; i++) {`