Address cppcheck suppressions in lmdb

eduar-hte · eduar-hte · commit 0cd2f459f319 · 2024-04-28T14:55:49.000-03:00
diff --git a/src/collection/backend/lmdb.cc b/src/collection/backend/lmdb.cc
@@ -659,7 +659,7 @@ MDB_dbi* MDBEnvProvider::GetDBI() {
     return &m_dbi;
 }
 
-bool MDBEnvProvider::isValid() {
+bool MDBEnvProvider::isValid() const {
     return valid;
 }
 
diff --git a/src/collection/backend/lmdb.h b/src/collection/backend/lmdb.h
@@ -83,7 +83,7 @@ class MDBEnvProvider {
     }
     MDB_env* GetEnv();
     MDB_dbi* GetDBI();
-    bool isValid();
+    bool isValid() const;
 
     ~MDBEnvProvider();
  private:
diff --git a/test/cppcheck_suppressions.txt b/test/cppcheck_suppressions.txt
@@ -59,9 +59,6 @@ unreadVariable:src/rule_with_operator.cc:219
 uninitvar:src/operators/verify_cpf.cc:77
 uninitvar:src/operators/verify_svnr.cc:67
 
-functionConst:src/collection/backend/lmdb.h:86
-unusedLabel:src/collection/backend/lmdb.cc:297
-
 variableScope:src/operators/rx.cc
 variableScope:src/operators/rx_global.cc
 

Original file line number	Diff line number	Diff line change
`@@ -659,7 +659,7 @@ MDB_dbi* MDBEnvProvider::GetDBI() {`
`659`	`659`	`return &m_dbi;`
`660`	`660`	`}`
`661`	`661`
`662`		`-bool MDBEnvProvider::isValid() {`
	`662`	`+bool MDBEnvProvider::isValid() const {`
`663`	`663`	`return valid;`
`664`	`664`	`}`
`665`	`665`