chore: apply flake8 linting

Signed-off-by: Adrien Barreau <adrien.barreau@ovhcloud.com>

Author: deathiop

.flake8

@@ -0,0 +1,6 @@
+[pycodestyle]
+max_line_length = 120
+
+[flake8]
+max-line-length = 120
+ignore = W503

docs/conf.py

@@ -12,9 +12,6 @@
 # All configuration values have a default; values that are commented out
 # serve to show the default.
 
-import os
-import sys
-
 # If extensions (or modules to document with autodoc) are in another directory,
 # add these directories to sys.path here. If the directory is relative to the
 # documentation root, use os.path.abspath to make it absolute, like shown here.
@@ -188,11 +185,11 @@
 
 latex_elements = {
     # The paper size ('letterpaper' or 'a4paper').
-    #'papersize': 'letterpaper',
+    # 'papersize': 'letterpaper',
     # The font size ('10pt', '11pt' or '12pt').
-    #'pointsize': '10pt',
+    # 'pointsize': '10pt',
     # Additional stuff for the LaTeX preamble.
-    #'preamble': '',
+    # 'preamble': '',
 }
 
 # Grouping the document tree into LaTeX files. List of tuples

ovh/__init__.py

@@ -26,6 +26,7 @@
 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
 # SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
+# flake8: noqa
 from .client import Client
 from .consumer_key import API_READ_ONLY, API_READ_WRITE, API_READ_WRITE_SAFE, ConsumerKeyRequest
 from .exceptions import (

ovh/client.py

@@ -38,17 +38,15 @@
 import json
 import keyword
 import time
-import urllib
 
 try:
     from urllib import urlencode
 except ImportError:  # pragma: no cover
     # Python 3
     from urllib.parse import urlencode
 
-from requests import Session, request
+from requests import Session
 from requests.exceptions import RequestException
-from requests.packages import urllib3
 
 from .config import config
 from .consumer_key import ConsumerKeyRequest
@@ -189,7 +187,7 @@ def __init__(
         # Override default timeout
         self._timeout = timeout
 
-    ## high level API
+    # high level API
 
     @property
     def time_delta(self):
@@ -230,7 +228,7 @@ def new_consumer_key_request(self):
             'consumerKey': 'TnpZAd5pYNqxk4RhlPiSRfJ4WrkmII2i',
             'validationUrl': 'https://eu.api.ovh.com/auth/?credentialToken=now2OOAVO4Wp6t7bemyN9DMWIobhGjFNZSHmixtVJM4S7mzjkN2L5VBfG96Iy1i0'
         }
-        """
+        """  # noqa:E501
         return ConsumerKeyRequest(self)
 
     def request_consumerkey(self, access_rules, redirect_url=None):
@@ -294,7 +292,7 @@ def request_consumerkey(self, access_rules, redirect_url=None):
         self._consumer_key = res["consumerKey"]
         return res
 
-    ## API shortcuts
+    # API shortcuts
 
     def _canonicalize_kwargs(self, kwargs):
         """
@@ -413,7 +411,7 @@ def delete(self, _target, _need_auth=True, **kwargs):
 
         return self.call("DELETE", _target, None, _need_auth)
 
-    ## low level helpers
+    # low level helpers
 
     def call(self, method, path, data=None, need_auth=True):
         """

ovh/consumer_key.py

@@ -74,7 +74,7 @@ def request(self, redirect_url=None):
             'consumerKey': 'TnpZAd5pYNqxk4RhlPiSRfJ4WrkmII2i',
             'validationUrl': 'https://eu.api.ovh.com/auth/?credentialToken=now2OOAVO4Wp6t7bemyN9DMWIobhGjFNZSHmixtVJM4S7mzjkN2L5VBfG96Iy1i0'
         }
-        """
+        """  # noqa: E501
         return self._client.request_consumerkey(self._access_rules, redirect_url)
 
     def add_rule(self, method, path):

tests/test_client.py

@@ -46,7 +46,6 @@
     NetworkError,
     NotCredential,
     NotGrantedCall,
-    ReadOnlyError,
     ResourceConflictError,
     ResourceExpiredError,
     ResourceNotFoundError,
@@ -84,7 +83,7 @@ def setUp(self):
     def tearDown(self):
         self.time_patch.stop()
 
-    ## test helpers
+    # test helpers
 
     def test_init(self):
         # nominal
@@ -168,7 +167,7 @@ def test_new_consumer_key_request(self):
         ck = api.new_consumer_key_request()
         self.assertEqual(ck._client, api)
 
-    ## test wrappers
+    # test wrappers
 
     def test__canonicalize_kwargs(self):
         api = Client(ENDPOINT, APPLICATION_KEY, APPLICATION_SECRET, CONSUMER_KEY)
@@ -209,7 +208,7 @@ def test_get(self, m_call):
         self.assertEqual(m_call.return_value, api.get(FAKE_URL, _from="start", to="end"))
         try:
             m_call.assert_called_once_with("GET", FAKE_URL + "?to=end&from=start", None, True)
-        except:
+        except Exception:
             m_call.assert_called_once_with("GET", FAKE_URL + "?from=start&to=end", None, True)
 
     @mock.patch.object(Client, "call")
@@ -243,7 +242,7 @@ def test_delete(self, m_call):
         self.assertEqual(m_call.return_value, api.delete(FAKE_URL, _from="start", to="end"))
         try:
             m_call.assert_called_once_with("DELETE", FAKE_URL + "?to=end&from=start", None, True)
-        except:
+        except Exception:
             m_call.assert_called_once_with("DELETE", FAKE_URL + "?from=start&to=end", None, True)
 
     @mock.patch.object(Client, "call")
@@ -284,7 +283,7 @@ def test_put_no_body(self, m_call):
         self.assertEqual(m_call.return_value, api.put(FAKE_URL))
         m_call.assert_called_once_with("PUT", FAKE_URL, None, True)
 
-    ## test core function
+    # test core function
 
     @mock.patch("ovh.client.Session.request")
     def test_call_no_sign(self, m_req):
@@ -366,7 +365,6 @@ def test_call_no_sign(self, m_req):
     @mock.patch("ovh.client.Session.request")
     def test_call_query_id(self, m_req):
         m_res = m_req.return_value
-        m_json = m_res.json.return_value
         m_res.headers = {"X-OVH-QUERYID": "FR.test1"}
 
         api = Client(ENDPOINT, APPLICATION_KEY, APPLICATION_SECRET)