Skip to content

Test/scenario 5 ultra clean #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Test/scenario 5 ultra clean #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5099348
Add CI fix: disable state locking
jameslaneovermind Oct 29, 2025
36544b2
Create ultra-clean VPC CIDR test scenario
jameslaneovermind Oct 29, 2025
5abb4ce
Fix outputs.tf to disable memory optimization outputs
jameslaneovermind Oct 29, 2025
8bf6933
Fix approach: Enable memory module with clean defaults instead of dis…
jameslaneovermind Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/automatic.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ jobs:
id: plan
run: |
set -o pipefail -ex
terraform plan -compact-warnings -no-color -input=false -lock-timeout=5m -out tfplan 2>&1 \
terraform plan -compact-warnings -no-color -input=false -lock=false -out tfplan 2>&1 \
| tee terraform_log
terraform show -json tfplan > tfplan.json

Expand Down Expand Up @@ -154,7 +154,7 @@ jobs:
id: plan-cost
run: |
set -o pipefail -ex
terraform plan -compact-warnings -no-color -input=false -lock-timeout=5m -out tfplan-cost 2>&1
terraform plan -compact-warnings -no-color -input=false -lock=false -out tfplan-cost 2>&1
terraform show -json tfplan-cost > tfplan-cost.json

- uses: overmindtech/cost-signals-action@v1
Expand Down
14 changes: 7 additions & 7 deletions modules/scenarios/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ module "vpc" {
# we expect this to be fixed over the coming weeks, as of 23/6/2025
version = "< 6.0"

name = "workloads-${var.example_env}"
cidr = "10.0.0.0/16"
name = "workloads-ultra-clean-test"
cidr = "172.16.0.0/16"

default_security_group_egress = [
{
Expand Down Expand Up @@ -66,7 +66,7 @@ module "vpc" {
}
}

# Memory optimization demo scenario
# Memory optimization demo scenario - ENABLED with clean defaults
module "memory_optimization" {
source = "./memory-optimization"

Expand All @@ -78,10 +78,10 @@ module "memory_optimization" {
vpc_id = module.vpc.vpc_id
subnet_ids = module.vpc.public_subnets

# Demo configuration
name_prefix = "scenarios-memory-demo"
container_memory = var.memory_optimization_container_memory
number_of_containers = var.memory_optimization_container_count
# Demo configuration - using clean defaults
name_prefix = "scenarios-clean-test"
container_memory = 2048 # Clean default, no memory reduction
number_of_containers = 1

# Context for the demo
days_until_black_friday = var.days_until_black_friday
Expand Down