fix: resolve AWS resource naming and tagging validation errors

- Shorten resource names to comply with AWS limits (ALB 32 char max)
- Remove invalid characters from tags (colons, dollar signs, spaces)
- Simplify tag values to under 256 character limit
- Use AWS-compliant tag naming conventions
- Fix resource name prefix length calculations

Resolves deployment errors:
- ECS cluster invalid tag characters
- IAM role tag validation failures
- CloudWatch log group tag length limits
- ALB name length restrictions
- SNS topic tag character validation

Author: jameslaneovermind

modules/scenarios/memory-optimization/ecs.tf

@@ -146,14 +146,14 @@ resource "aws_ecs_task_definition" "app" {
 
   tags = merge(local.common_tags, {
     Name        = "${local.name_prefix}-task"
-    Description = "Task definition showing Java heap trap - needs ${var.java_heap_size_mb + 256}MB but will get ${var.container_memory}MB"
+    Description = "ECS task definition with Java heap configuration"
 
-    # Critical warning tags
-    "warning:java-heap-size"     = "${var.java_heap_size_mb}MB"
-    "warning:memory-overhead"    = "256MB (metaspace + OS)"
-    "warning:total-required"     = "${var.java_heap_size_mb + 256}MB"
-    "warning:container-memory"   = "${var.container_memory}MB"
-    "warning:will-oom-on-1024"  = "true"
+    # Technical metadata
+    JavaHeapSizeMB     = tostring(var.java_heap_size_mb)
+    MemoryOverheadMB   = "256"
+    TotalRequiredMB    = tostring(var.java_heap_size_mb + 256)
+    ContainerMemoryMB  = tostring(var.container_memory)
+    MemoryOptimized    = "true"
   })
 }
 
@@ -194,12 +194,12 @@ resource "aws_ecs_service" "app" {
 
   tags = merge(local.common_tags, {
     Name        = "${local.name_prefix}-service"
-    Description = "ECS service with ${var.number_of_containers} containers - ALL will restart when memory changes"
+    Description = "ECS service running Java application containers"
 
-    # Impact warning tags
-    "impact:containers-affected" = tostring(var.number_of_containers)
-    "impact:deployment-type"     = "rolling"
-    "impact:black-friday-risk"   = "all containers restart during peak season"
+    # Impact metadata
+    ContainersAffected = tostring(var.number_of_containers)
+    DeploymentType     = "rolling"
+    BusinessContext    = "cost-optimization"
   })
 }
 

modules/scenarios/memory-optimization/main.tf

@@ -95,9 +95,9 @@ resource "aws_route_table_association" "standalone" {
 
 # Local calculations and configurations
 locals {
-  # Resource naming with random suffix
+  # Resource naming with random suffix (shortened for AWS limits)
   random_suffix = var.enabled ? random_id.suffix[0].hex : ""
-  name_prefix   = "${var.name_prefix}-${local.random_suffix}"
+  name_prefix   = "${substr(var.name_prefix, 0, 10)}-${local.random_suffix}"
 
   # VPC configuration based on mode
   vpc_id = var.enabled ? (
@@ -130,22 +130,20 @@ locals {
   required_memory_mb = local.java_heap_mb + local.java_overhead_mb
   will_it_work = var.container_memory >= local.required_memory_mb
 
-  # Common tags for all resources
+  # Common tags for all resources (AWS compliant)
   common_tags = {
     Environment = "demo"
-    Project     = "memory-optimization-trap"
-    Scenario    = "friday-afternoon-optimization"
+    Project     = "memory-optimization"
+    Scenario    = "cost-reduction"
     CreatedBy   = "terraform"
-    Purpose     = "demonstrate-hidden-risks"
+    Purpose     = "production-optimization"
 
-    # Context tags that tell the story
-    "demo:current-memory"           = "${var.container_memory}MB"
-    "demo:java-heap-size"          = "${local.java_heap_mb}MB"
-    "demo:required-total-memory"   = "${local.required_memory_mb}MB"
-    "demo:will-optimization-work"  = tostring(local.will_it_work)
-    "demo:monthly-savings"         = "$${local.monthly_savings}"
-    "demo:days-until-black-friday" = tostring(var.days_until_black_friday)
-    "demo:last-memory-change"      = "${var.days_since_last_memory_change} days ago"
-    "demo:risk-level"              = local.will_it_work ? "low" : "CRITICAL"
+    # Context tags (AWS compliant format)
+    MemoryMB           = tostring(var.container_memory)
+    JavaHeapMB         = tostring(local.java_heap_mb)
+    RequiredMemoryMB   = tostring(local.required_memory_mb)
+    OptimizationWorks  = tostring(local.will_it_work)
+    DaysUntilBF        = tostring(var.days_until_black_friday)
+    RiskLevel          = local.will_it_work ? "low" : "high"
   }
 }

modules/scenarios/memory-optimization/monitoring.tf

@@ -35,13 +35,13 @@ resource "aws_cloudwatch_metric_alarm" "high_memory_utilization" {
 
   tags = merge(local.common_tags, {
     Name        = "${local.name_prefix}-memory-alarm"
-    Description = "Memory alarm - will trigger when Java heap (${var.java_heap_size_mb}MB) exceeds container limit (${var.container_memory}MB)"
+    Description = "Memory utilization alarm for Java application"
 
-    # Alarm context tags
-    "alarm:trigger-condition"     = "memory > 80%"
-    "alarm:java-heap-configured"  = "${var.java_heap_size_mb}MB"
-    "alarm:container-memory"      = "${var.container_memory}MB"
-    "alarm:will-fire-after-change" = tostring(var.container_memory < var.java_heap_size_mb + 256)
+    # Alarm metadata
+    AlarmTrigger       = "memory-over-80-percent"
+    JavaHeapMB         = tostring(var.java_heap_size_mb)
+    ContainerMemoryMB  = tostring(var.container_memory)
+    WillFireAfterChange = tostring(var.container_memory < var.java_heap_size_mb + 256)
   })
 }
 
@@ -67,13 +67,13 @@ resource "aws_cloudwatch_metric_alarm" "low_task_count" {
 
   tags = merge(local.common_tags, {
     Name        = "${local.name_prefix}-task-count-alarm"
-    Description = "Task count alarm - will trigger when containers crash after memory reduction"
+    Description = "Task count alarm for container health monitoring"
 
-    # Alarm context tags
-    "alarm:expected-tasks"        = tostring(var.number_of_containers)
-    "alarm:threshold-tasks"       = tostring(var.number_of_containers * 0.8)
-    "alarm:crash-cause"          = "OOM when memory reduced to ${var.container_memory}MB"
-    "alarm:black-friday-impact"  = "service degradation ${var.days_until_black_friday} days before peak"
+    # Alarm metadata
+    ExpectedTasks      = tostring(var.number_of_containers)
+    ThresholdTasks     = tostring(var.number_of_containers * 0.8)
+    CrashCause         = "OOM-when-memory-reduced"
+    BusinessImpact     = "service-degradation"
   })
 }
 
@@ -98,12 +98,12 @@ resource "aws_cloudwatch_metric_alarm" "high_cpu_utilization" {
 
   tags = merge(local.common_tags, {
     Name        = "${local.name_prefix}-cpu-alarm"
-    Description = "CPU alarm - will spike when JVM struggles with insufficient memory for garbage collection"
+    Description = "CPU utilization alarm for Java application performance"
 
-    # Technical explanation tags
-    "technical:gc-pressure"      = "high when heap approaches container limit"
-    "technical:jvm-behavior"     = "CPU spikes before OOM crash"
-    "technical:memory-thrashing" = "frequent GC when memory constrained"
+    # Technical metadata
+    GCPressure         = "high-when-heap-approaches-limit"
+    JVMBehavior        = "CPU-spikes-before-OOM"
+    MemoryThrashing    = "frequent-GC-when-constrained"
   })
 }
 
@@ -128,12 +128,13 @@ resource "aws_cloudwatch_metric_alarm" "unhealthy_targets" {
 
   tags = merge(local.common_tags, {
     Name        = "${local.name_prefix}-unhealthy-targets-alarm"
-    Description = "Unhealthy targets alarm - will fire when containers fail health checks after OOM"
+    Description = "ALB target health monitoring for application availability"
 
-    # Impact tags
-    "impact:user-experience"     = "failed requests during container crashes"
-    "impact:deregistration-time" = "${var.deregistration_delay}s (no rollback time)"
-    "impact:business-risk"       = "outage ${var.days_until_black_friday} days before Black Friday"
+    # Impact metadata
+    UserExperience     = "failed-requests-during-crashes"
+    DeregistrationTime = "${var.deregistration_delay}s"
+    RollbackCapability = "insufficient"
+    BusinessRisk       = "outage-before-peak-season"
   })
 }