Merge pull request #720 from Kocal/re-add-isser-support

fix(field-resolver): re-add support for isser methods

Author: mcg-web

UPGRADE-0.13.md

@@ -23,7 +23,7 @@ The new `default_field_resolver` config entry accepts callable service id.
 Stop using internally `symfony/property-access` package
 since it was a bottleneck to performance for large schema.
 
-Array access and camelize getter are supported but isser, hasser,
+Array access and camelize getter/isser are supported but hasser,
 jQuery style (e.g. `last()`) and "can" property accessors
 are no more supported out-of-the-box,
 please implement a custom resolver if these accessors are needed.

src/Resolver/FieldResolver.php

@@ -24,6 +24,8 @@ public static function valueFromObjectOrArray($objectOrArray, $fieldName)
         } elseif (\is_object($objectOrArray)) {
             if (null !== $getter = self::guessObjectMethod($objectOrArray, $fieldName, 'get')) {
                 $value = $objectOrArray->$getter();
+            } elseif (null !== $getter = self::guessObjectMethod($objectOrArray, $fieldName, 'is')) {
+                $value = $objectOrArray->$getter();
             } elseif (isset($objectOrArray->$fieldName)) {
                 $value = $objectOrArray->$fieldName;
             }

tests/Resolver/ResolverFieldTest.php

@@ -38,6 +38,7 @@ public function resolverProvider()
             ['private_property_with_getter2', $object, Toto::PRIVATE_PROPERTY_WITH_GETTER2_VALUE],
             ['not_object_or_array', 'String', null],
             ['name', $object, $object->name],
+            ['enabled', $object, $object->isEnabled()],
         ];
     }
 }

tests/Resolver/Toto.php

@@ -14,6 +14,7 @@ class Toto
     private $privatePropertyWithGetter = self::PRIVATE_PROPERTY_WITH_GETTER_VALUE;
     private $private_property_with_getter2 = self::PRIVATE_PROPERTY_WITH_GETTER2_VALUE;
     public $name = 'public';
+    private $enabled = true;
 
     /**
      * @return string
@@ -42,4 +43,12 @@ public function resolve()
     {
         return \func_get_args();
     }
+
+    /**
+     * @return bool
+     */
+    public function isEnabled()
+    {
+        return $this->enabled;
+    }
 }