Fix static analyse build

Author: Jeremiah VALERIE

phpstan-baseline.neon

@@ -25,7 +25,9 @@ public static function getMetadatas(Reflector $reflector): array
             case $reflector instanceof ReflectionMethod:
             case $reflector instanceof ReflectionProperty:
             case $reflector instanceof ReflectionClassConstant:
-                $attributes = $reflector->getAttributes();
+                if (is_callable([$reflector, 'getAttributes'])) {
+                    $attributes = $reflector->getAttributes();
+                }
         }
 
         // @phpstan-ignore-next-line

src/Config/Parser/AttributeParser.php

@@ -42,7 +42,7 @@ class GraphQLParser implements ParserInterface
     public static function parse(SplFileInfo $file, ContainerBuilder $container, array $configs = []): array
     {
         $container->addResource(new FileResource($file->getRealPath()));
-        $content = trim(file_get_contents($file->getPathname()));
+        $content = trim((string) file_get_contents($file->getPathname()));
         $typesConfig = [];
 
         // allow empty files

src/Config/Parser/GraphQLParser.php

@@ -13,7 +13,6 @@
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Definition;
 use function array_filter;
-use function call_user_func;
 use function is_subclass_of;
 
 final class AliasedPass implements CompilerPassInterface
@@ -65,7 +64,11 @@ private function filterDefinitions(array $definitions): array
 
     private function addDefinitionTagsFromAliases(Definition $definition): void
     {
-        $aliases = call_user_func([$definition->getClass(), 'getAliases']);
+        /**
+         * @var class-string<AliasedInterface> $class
+         */
+        $class = (string) $definition->getClass();
+        $aliases = $class::getAliases();
         /** @var string $tagName */
         $tagName = $this->guessTagName($definition);
         $withMethod = TypeTaggedServiceMappingPass::TAG_NAME !== $tagName;

src/DependencyInjection/Compiler/AliasedPass.php

@@ -27,7 +27,6 @@
 use function array_map;
 use function array_merge;
 use function array_replace_recursive;
-use function call_user_func;
 use function dirname;
 use function implode;
 use function is_a;
@@ -43,6 +42,9 @@ class ConfigParserPass implements CompilerPassInterface
         'attribute' => 'php',
     ];
 
+    /**
+     * @var array<string, class-string<PreParserInterface>>
+     */
     public const PARSERS = [
         'yaml' => YamlParser::class,
         'graphql' => GraphQLParser::class,
@@ -143,7 +145,10 @@ private function parseTypeConfigFiles(string $type, iterable $files, ContainerBu
                 continue;
             }
 
-            $config[] = call_user_func([self::PARSERS[$type], $method], $file, $container, $configs);
+            $parser = [self::PARSERS[$type], $method];
+            if (is_callable($parser)) {
+                $config[] = ($parser)($file, $container, $configs);
+            }
             $treatedFiles[$file->getRealPath()] = true;
         }
 

src/DependencyInjection/Compiler/ConfigParserPass.php

@@ -95,10 +95,10 @@ private function treatExceptions(array $errors, bool $throwRawException): array
                 continue;
             }
 
-            // recreate a error with converted exception
+            // recreate an error with converted exception
             $errorWithConvertedException = new GraphQLError(
                 $error->getMessage(),
-                $error->nodes,
+                $error->nodes, // @phpstan-ignore-line
                 $error->getSource(),
                 $error->getPositions(),
                 $error->path,

src/Error/ErrorHandler.php

@@ -139,7 +139,7 @@ public static function stringHasTrigger(string $maybeExpression): bool
      */
     public static function unprefixExpression(string $expression)
     {
-        $string = substr($expression, strlen(self::EXPRESSION_TRIGGER));
+        $string = substr($expression, strlen(self::EXPRESSION_TRIGGER)) ?: '';
 
         return '' !== $string ? $string : $expression;
     }

src/ExpressionLanguage/ExpressionLanguage.php

@@ -77,7 +77,7 @@ public function validate($groups = null, bool $throw = true): ?ConstraintViolati
 
         $this->buildValidationTree(
             $rootNode,
-            $this->info->fieldDefinition->config['args'],
+            $this->info->fieldDefinition->config['args'] ?? [],
             $classMapping,
             $this->resolverArgs->args->getArrayCopy()
         );
@@ -95,7 +95,9 @@ public function validate($groups = null, bool $throw = true): ?ConstraintViolati
 
     private function mergeClassValidation(): array
     {
+        /** @phpstan-ignore-next-line */
         $common = static::normalizeConfig($this->info->parentType->config['validation'] ?? []);
+        /** @phpstan-ignore-next-line */
         $specific = static::normalizeConfig($this->info->fieldDefinition->config['validation'] ?? []);
 
         return array_filter([
@@ -127,7 +129,7 @@ private function createValidator(MetadataFactory $metadataFactory): ValidatorInt
      * Creates a composition of ValidationNode objects from args
      * and simultaneously applies to them validation constraints.
      */
-    protected function buildValidationTree(ValidationNode $rootObject, array $fields, array $classValidation, array $inputData): ValidationNode
+    private function buildValidationTree(ValidationNode $rootObject, iterable $fields, array $classValidation, array $inputData): ValidationNode
     {
         $metadata = new ObjectMetadata($rootObject);
 
@@ -171,6 +173,7 @@ protected function buildValidationTree(ValidationNode $rootObject, array $fields
                         [$fqcn, $property, $type] = $value;
 
                         if (!in_array($fqcn, $this->cachedMetadata)) {
+                            /** @phpstan-ignore-next-line */
                             $this->cachedMetadata[$fqcn] = $this->defaultValidator->getMetadataFor($fqcn);
                         }
 
@@ -238,6 +241,7 @@ private function createCollectionNode(array $values, $type, ValidationNode $pare
      */
     private function createObjectNode(array $value, $type, ValidationNode $parent): ValidationNode
     {
+        /** @phpstan-ignore-next-line */
         $classValidation = static::normalizeConfig($type->config['validation'] ?? []);
 
         return $this->buildValidationTree(

src/Validator/InputValidator.php

@@ -17,6 +17,9 @@ public function __construct()
         $this->metadataPool = [];
     }
 
+    /**
+     * @param mixed $object
+     */
     public function getMetadataFor($object): ObjectMetadata
     {
         if ($object instanceof ValidationNode) {
@@ -26,6 +29,9 @@ public function getMetadataFor($object): ObjectMetadata
         throw new NoSuchMetadataException();
     }
 
+    /**
+     * @param mixed $object
+     */
     public function hasMetadataFor($object): bool
     {
         if ($object instanceof ValidationNode) {

src/Validator/Mapping/MetadataFactory.php

@@ -21,7 +21,7 @@ public function __construct(ValidationNode $object)
      *
      * @return $this|ObjectMetadata
      */
-    public function addPropertyConstraint($property, Constraint $constraint)
+    public function addPropertyConstraint($property, Constraint $constraint): self
     {
         if (!isset($this->properties[$property])) {
             $this->properties[$property] = new PropertyMetadata($property);