Merge pull request #1051 from sparklink-pro/phpcs

Update PHPCs to latest version & fix files

Author: Vincz

composer.json

@@ -91,7 +91,7 @@
         "static-analysis": [
             "phpstan analyse --ansi --memory-limit=1G"
         ],
-        "install-cs": "test -f php-cs-fixer.phar || wget https://github.com/FriendsOfPHP/PHP-CS-Fixer/releases/download/v3.3.2/php-cs-fixer.phar -O php-cs-fixer.phar",
+        "install-cs": "test -f php-cs-fixer.phar || wget https://github.com/FriendsOfPHP/PHP-CS-Fixer/releases/download/v3.11.0/php-cs-fixer.phar -O php-cs-fixer.phar",
         "fix-cs": [
             "@install-cs",
             "@php php-cs-fixer.phar fix --diff -v --allow-risky=yes --ansi"

src/Command/DebugCommand.php

@@ -11,6 +11,7 @@
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Style\SymfonyStyle;
+
 use function array_diff;
 use function array_keys;
 use function implode;

src/Command/GraphQLDumpSchemaCommand.php

@@ -13,11 +13,13 @@
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Style\SymfonyStyle;
+
 use function file_put_contents;
 use function json_encode;
 use function realpath;
 use function sprintf;
 use function strtolower;
+
 use const JSON_PRETTY_PRINT;
 
 final class GraphQLDumpSchemaCommand extends Command

src/Config/EnumTypeDefinition.php

@@ -5,6 +5,7 @@
 namespace Overblog\GraphQLBundle\Config;
 
 use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
+
 use function array_key_exists;
 use function is_array;
 use function is_null;

src/Config/InputObjectTypeDefinition.php

@@ -5,6 +5,7 @@
 namespace Overblog\GraphQLBundle\Config;
 
 use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
+
 use function is_string;
 
 final class InputObjectTypeDefinition extends TypeDefinition

src/Config/ObjectTypeDefinition.php

@@ -6,6 +6,7 @@
 
 use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
 use Symfony\Component\Config\Definition\Builder\TreeBuilder;
+
 use function array_key_exists;
 
 final class ObjectTypeDefinition extends TypeWithOutputFieldsDefinition

src/Config/Parser/GraphQL/ASTConverter/DescriptionNode.php

@@ -6,6 +6,7 @@
 
 use GraphQL\Language\AST\Node;
 use GraphQL\Language\AST\StringValueNode;
+
 use function trim;
 
 final class DescriptionNode implements NodeInterface

src/Config/Parser/GraphQLParser.php

@@ -15,12 +15,12 @@
 use Symfony\Component\Config\Resource\FileResource;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Exception\InvalidArgumentException;
+
 use function array_keys;
 use function array_pop;
 use function call_user_func;
 use function explode;
 use function file_get_contents;
-use function get_class;
 use function in_array;
 use function preg_replace;
 use function sprintf;
@@ -79,7 +79,7 @@ public static function parse(SplFileInfo $file, ContainerBuilder $container, arr
 
     private static function throwUnsupportedDefinitionNode(DefinitionNode $typeDef): void
     {
-        $path = explode('\\', get_class($typeDef));
+        $path = explode('\\', $typeDef::class);
         throw new InvalidArgumentException(
             sprintf(
                 '%s definition is not supported right now.',

src/Config/Parser/MetadataParser/MetadataParser.php

@@ -25,6 +25,7 @@
 use Symfony\Component\Config\Resource\FileResource;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Exception\InvalidArgumentException;
+
 use function array_filter;
 use function array_keys;
 use function array_map;
@@ -250,6 +251,7 @@ private static function classMetadatasToGQLConfiguration(
 
     /**
      * @throws ReflectionException
+     *
      * @phpstan-param class-string $className
      */
     private static function getClassReflection(string $className): ReflectionClass
@@ -510,9 +512,9 @@ private static function unionMetadataToGQLConfiguration(ReflectionClass $reflect
      * @phpstan-param ReflectionMethod|ReflectionProperty $reflector
      * @phpstan-param class-string<Metadata\Field> $fieldMetadataName
      *
-     * @throws AnnotationException
-     *
      * @return array<string,array>
+     *
+     * @throws AnnotationException
      */
     private static function getTypeFieldConfigurationFromReflector(ReflectionClass $reflectionClass, Reflector $reflector, string $fieldMetadataName, string $currentValue = 'value'): array
     {
@@ -623,9 +625,9 @@ private static function getTypeFieldConfigurationFromReflector(ReflectionClass $
      *
      * @param ReflectionProperty[] $reflectors
      *
-     * @throws AnnotationException
-     *
      * @return array<string,array>
+     *
+     * @throws AnnotationException
      */
     private static function getGraphQLInputFieldsFromMetadatas(ReflectionClass $reflectionClass, array $reflectors): array
     {
@@ -832,7 +834,9 @@ private static function formatNamespaceForExpression(string $namespace): string
      * Get the first metadata matching given class.
      *
      * @phpstan-template T of object
+     *
      * @phpstan-param class-string<T>|class-string<T>[] $metadataClasses
+     *
      * @phpstan-return T|null
      *
      * @return object|null
@@ -848,6 +852,7 @@ private static function getFirstMetadataMatching(array $metadatas, $metadataClas
      * Return the metadata matching given class
      *
      * @phpstan-template T of object
+     *
      * @phpstan-param class-string<T>|class-string<T>[] $metadataClasses
      *
      * @return array

src/Config/Parser/MetadataParser/TypeGuesser/DocBlockTypeGuesser.php

@@ -19,6 +19,7 @@
 use ReflectionMethod;
 use ReflectionProperty;
 use Reflector;
+
 use function sprintf;
 
 final class DocBlockTypeGuesser extends PhpTypeGuesser