Add missing test & remove useless methods from GraphClass

Author: Vincz

src/Config/Parser/Annotation/GraphClass.php

@@ -8,7 +8,6 @@
 use Doctrine\Common\Annotations\AnnotationReader;
 use Doctrine\Common\Annotations\AnnotationRegistry;
 use ReflectionClass;
-use ReflectionException;
 use ReflectionMethod;
 use ReflectionProperty;
 use RuntimeException;
@@ -40,43 +39,6 @@ public function __construct(string $className)
         } while ($reflection = $reflection->getParentClass());
     }
 
-    /**
-     * Get an array of parent class names.
-     *
-     * @return string[]
-     */
-    public function getParents(): array
-    {
-        $parents = [];
-        $class = $this;
-        while ($parent = $class->getParentClass()) {
-            $parents[] = $parent->getName();
-            $class = $parent;
-        }
-
-        return $parents;
-    }
-
-    /**
-     * Get the list of methods name.
-     *
-     * @return string[]
-     */
-    public function getMethodsNames(): array
-    {
-        return array_map(fn (ReflectionMethod $method) => $method->getName(), $this->getMethods());
-    }
-
-    public function getMethodAnnotations(string $name): array
-    {
-        return self::getAnnotationReader()->getMethodAnnotations($this->getMethod($name));
-    }
-
-    public function getPropertyAnnotations(string $name): array
-    {
-        return self::getAnnotationReader()->getPropertyAnnotations($this->getProperty($name));
-    }
-
     /**
      * @return ReflectionProperty[]
      */
@@ -85,15 +47,6 @@ public function getPropertiesExtended()
         return $this->propertiesExtended;
     }
 
-    public function getPropertyExtended(string $name): ReflectionProperty
-    {
-        if (!isset($this->propertiesExtended[$name])) {
-            throw new ReflectionException(sprintf('Missing property %s on class or parent class %s', $name, $this->getName()));
-        }
-
-        return $this->propertiesExtended[$name];
-    }
-
     /**
      * @param ReflectionMethod|ReflectionProperty|null $from
      *

src/Config/Parser/AnnotationParser.php

@@ -304,7 +304,7 @@ private static function graphQLTypeConfigFromAnnotation(GraphClass $graphClass,
         if (null !== $typeAnnotation->interfaces) {
             $typeConfiguration['interfaces'] = $typeAnnotation->interfaces;
         } else {
-            $typeConfiguration['interfaces'] = array_keys(self::searchClassesMapBy(function ($gqlType, $configuration) use ($graphClass) {
+            $interfaces = array_keys(self::searchClassesMapBy(function ($gqlType, $configuration) use ($graphClass) {
                 ['class' => $interfaceClassName] = $configuration;
 
                 $interfaceMetadata = self::getGraphClass($interfaceClassName);
@@ -314,6 +314,9 @@ private static function graphQLTypeConfigFromAnnotation(GraphClass $graphClass,
 
                 return $graphClass->isSubclassOf($interfaceClassName);
             }, self::GQL_INTERFACE));
+
+            sort($interfaces);
+            $typeConfiguration['interfaces'] = $interfaces;
         }
 
         if ($typeAnnotation->resolveField) {

tests/Config/Parser/AnnotationParserTest.php

@@ -224,7 +224,7 @@ public function testUnionAutoguessed(): void
     public function testInterfaceAutoguessed(): void
     {
         $this->expect('Mandalorian', 'object', [
-            'interfaces' => ['Character'],
+            'interfaces' => ['Armored', 'Character'],
             'fields' => [
                 'name' => ['type' => 'String!', 'description' => 'The name of the character'],
                 'friends' => ['type' => '[Character]', 'description' => 'The friends of the character', 'resolve' => "@=resolver('App\\\\MyResolver::getFriends')"],

tests/Config/Parser/fixtures/annotations/Type/Armored.php

@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Overblog\GraphQLBundle\Tests\Config\Parser\fixtures\annotations\Type;
+
+use Overblog\GraphQLBundle\Annotation as GQL;
+
+/**
+ * @GQL\TypeInterface(resolveType="@=resolver('character_type', [value])")
+ * @GQL\Description("The armored interface")
+ */
+interface Armored
+{
+}

tests/Config/Parser/fixtures/annotations/Type/Mandalorian.php

@@ -10,6 +10,6 @@
 /**
  * @GQL\Type
  */
-class Mandalorian extends Character implements Killable
+class Mandalorian extends Character implements Killable, Armored
 {
 }