Update PHP CS Fixer and cleanup code

Author: Vincz

composer.json

@@ -91,7 +91,7 @@
         "static-analysis": [
             "phpstan analyse --ansi --memory-limit=1G"
         ],
-        "install-cs": "test -f php-cs-fixer.phar || wget https://github.com/FriendsOfPHP/PHP-CS-Fixer/releases/download/v3.11.0/php-cs-fixer.phar -O php-cs-fixer.phar",
+        "install-cs": "test -f php-cs-fixer.phar || wget https://github.com/FriendsOfPHP/PHP-CS-Fixer/releases/download/v3.17.0/php-cs-fixer.phar -O php-cs-fixer.phar",
         "fix-cs": [
             "@install-cs",
             "@php php-cs-fixer.phar fix --diff -v --allow-risky=yes --ansi"

src/Definition/Builder/SchemaBuilder.php

@@ -23,7 +23,7 @@ public function __construct(TypeResolver $typeResolver, bool $enableValidation =
         $this->enableValidation = $enableValidation;
     }
 
-    public function getBuilder(string $name, ?string $queryAlias, ?string $mutationAlias = null, ?string $subscriptionAlias = null, array $types = []): Closure
+    public function getBuilder(string $name, ?string $queryAlias, string $mutationAlias = null, string $subscriptionAlias = null, array $types = []): Closure
     {
         return function () use ($name, $queryAlias, $mutationAlias, $subscriptionAlias, $types): ExtensibleSchema {
             static $schema = null;
@@ -38,7 +38,7 @@ public function getBuilder(string $name, ?string $queryAlias, ?string $mutationA
     /**
      * @param string[] $types
      */
-    public function create(string $name, ?string $queryAlias, ?string $mutationAlias = null, ?string $subscriptionAlias = null, array $types = []): ExtensibleSchema
+    public function create(string $name, ?string $queryAlias, string $mutationAlias = null, string $subscriptionAlias = null, array $types = []): ExtensibleSchema
     {
         $this->typeResolver->setCurrentSchemaName($name);
         $query = $this->typeResolver->resolve($queryAlias);

src/Definition/Type/PhpEnumType.php

@@ -93,7 +93,7 @@ public function parseValue($value): mixed
         return parent::parseValue($value);
     }
 
-    public function parseLiteral(Node $valueNode, ?array $variables = null): mixed
+    public function parseLiteral(Node $valueNode, array $variables = null): mixed
     {
         if ($this->enumClass) {
             if (!$valueNode instanceof EnumValueNode) {

src/Executor/Executor.php

@@ -28,8 +28,8 @@ public function execute(
         $contextValue = null,
         $variableValues = null,
         $operationName = null,
-        ?callable $fieldResolver = null,
-        ?array $validationRules = null
+        callable $fieldResolver = null,
+        array $validationRules = null
     ): ExecutionResult {
         if (!method_exists($promiseAdapter, 'wait')) {
             throw new RuntimeException(

src/Executor/ExecutorInterface.php

@@ -25,7 +25,7 @@ public function execute(
         $contextValue = null,
         $variableValues = null,
         $operationName = null,
-        ?callable $fieldResolver = null,
-        ?array $validationRules = null
+        callable $fieldResolver = null,
+        array $validationRules = null
     ): ExecutionResult;
 }

src/ExpressionLanguage/ExpressionFunction.php

@@ -12,7 +12,7 @@ class ExpressionFunction extends BaseExpressionFunction
 {
     protected string $gqlServices = '$'.TypeGenerator::GRAPHQL_SERVICES;
 
-    public function __construct(string $name, callable $compiler, ?callable $evaluator = null)
+    public function __construct(string $name, callable $compiler, callable $evaluator = null)
     {
         if (null === $evaluator) {
             $evaluator = new EvaluatorIsNotAllowedException($name);

src/Generator/TypeBuilder.php

@@ -449,7 +449,7 @@ private function buildScalarCallback($callback, string $fieldName)
      *
      * @throws GeneratorException
      */
-    private function buildResolve($resolve, ?array $groups = null): GeneratorInterface
+    private function buildResolve($resolve, array $groups = null): GeneratorInterface
     {
         if (is_callable($resolve) && is_array($resolve)) {
             return Collection::numeric($resolve);

src/Generator/TypeGeneratorOptions.php

@@ -36,8 +36,8 @@ public function __construct(
         string $namespace,
         ?string $cacheDir,
         bool $useClassMap = true,
-        ?string $cacheBaseDir = null,
-        ?int $cacheDirMask = null
+        string $cacheBaseDir = null,
+        int $cacheDirMask = null
     ) {
         $this->namespace = $namespace;
         $this->cacheDir = $cacheDir;

src/Relay/Connection/ConnectionBuilder.php

@@ -59,7 +59,7 @@ final class ConnectionBuilder
      * @phpstan-param ConnectionFactoryFunc|null $connectionCallback
      * @phpstan-param EdgeFactoryFunc|null $edgeCallback
      */
-    public function __construct(?CursorEncoderInterface $cursorEncoder = null, ?callable $connectionCallback = null, ?callable $edgeCallback = null)
+    public function __construct(CursorEncoderInterface $cursorEncoder = null, callable $connectionCallback = null, callable $edgeCallback = null)
     {
         $this->cursorEncoder = $cursorEncoder ?? new Base64CursorEncoder();
         $this->connectionCallback = $connectionCallback ?? static fn (array $edges, PageInfoInterface $pageInfo): Connection => new Connection($edges, $pageInfo);

src/Relay/Connection/Output/Connection.php

@@ -26,7 +26,7 @@ class Connection implements ConnectionInterface
     protected ?PageInfoInterface $pageInfo;
 
     /** @var int|Promise|null Total count or promise that returns the total count */
-    protected $totalCount = null;
+    protected $totalCount;
 
     /**
      * @param EdgeInterface<T>[] $edges