Fix scrutinizer

Author: Vincz

src/Config/Parser/Annotation/GraphClass.php

@@ -119,8 +119,8 @@ public function getAnnotations(object $from = null)
     private static function getAnnotationReader(): AnnotationReader
     {
         if (null === self::$annotationReader) {
-            if (!class_exists('\\Doctrine\\Common\\Annotations\\AnnotationReader') ||
-                !class_exists('\\Doctrine\\Common\\Annotations\\AnnotationRegistry')) {
+            if (!class_exists(AnnotationReader::class) ||
+                !class_exists(AnnotationRegistry::class)) {
                 throw new RuntimeException('In order to use graphql annotation, you need to require doctrine annotations');
             }
 

src/Config/Parser/AnnotationParser.php

@@ -213,7 +213,8 @@ private static function classAnnotationsToGQLConfiguration(
                 if ($preProcess) {
                     self::$providers[] = ['metadata' => $graphClass, 'annotation' => $classAnnotation];
                 }
-                break;
+
+                return [];
         }
 
         if (null !== $gqlType) {
@@ -239,9 +240,7 @@ private static function classAnnotationsToGQLConfiguration(
      */
     private static function getGraphClass(string $className): GraphClass
     {
-        if (!isset(self::$graphClassCache[$className])) {
-            self::$graphClassCache[$className] = new GraphClass($className);
-        }
+        self::$graphClassCache[$className] ??= new GraphClass($className);
 
         return self::$graphClassCache[$className];
     }
@@ -302,7 +301,7 @@ private static function graphQLTypeConfigFromAnnotation(GraphClass $graphClass,
         $typeConfiguration['fields'] = array_merge($fieldsFromProperties, $fieldsFromMethods);
         $typeConfiguration = self::getDescriptionConfiguration($graphClass->getAnnotations()) + $typeConfiguration;
 
-        if ($typeAnnotation->interfaces) {
+        if (null !== $typeAnnotation->interfaces) {
             $typeConfiguration['interfaces'] = $typeAnnotation->interfaces;
         } else {
             $typeConfiguration['interfaces'] = array_keys(self::searchClassesMapBy(function ($gqlType, $configuration) use ($graphClass) {
@@ -435,7 +434,7 @@ private static function enumAnnotationToGQLConfiguration(GraphClass $graphClass,
     private static function unionAnnotationToGQLConfiguration(GraphClass $graphClass, GQL\Union $unionAnnotation): array
     {
         $unionConfiguration = [];
-        if ($unionAnnotation->types) {
+        if (null !== $unionAnnotation->types) {
             $unionConfiguration['types'] = $unionAnnotation->types;
         } else {
             $types = array_keys(self::searchClassesMapBy(function ($gqlType, $configuration) use ($graphClass) {
@@ -550,6 +549,7 @@ private static function getTypeFieldConfigurationFromReflector(GraphClass $graph
         } else {
             if (!$fieldType) {
                 if ($isMethod) {
+                    /** var ReflectionMethod $reflector */
                     if ($reflector->hasReturnType()) {
                         try {
                             $fieldConfiguration['type'] = self::resolveGraphQLTypeFromReflectionType($reflector->getReturnType(), self::VALID_OUTPUT_TYPES);