Merge pull request #1184 from joesaunderson/patch-1

Don't validate fields that were not passed

Author: Vincz

src/Validator/InputValidator.php

@@ -140,6 +140,11 @@ private function buildValidationTree(ValidationNode $rootObject, iterable $field
             $property = $arg['name'] ?? $name;
             $config = static::normalizeConfig($arg['validation'] ?? []);
 
+            if (!array_key_exists($property, $inputData)) {
+                // This field was not provided in the inputData. Do not attempt to validate it.
+                continue;
+            }
+
             if (isset($config['cascade']) && isset($inputData[$property])) {
                 $groups = $config['cascade'];
                 $argType = $this->unclosure($arg['type']);

tests/Functional/App/config/validator/mapping/Mutation.types.yml

@@ -138,3 +138,11 @@ Mutation:
                         validation:
                             cascade:
                                 groups: ['group2']
+
+            onlyPassedFieldsValidation:
+                type: Boolean
+                resolve: '@=m("mutation_mock", args)'
+                args:
+                    person:
+                        validation: cascade
+                        type: Person!

tests/Functional/App/config/validator/mapping/Person.types.yml

@@ -0,0 +1,14 @@
+Person:
+    type: input-object
+    config:
+        fields:
+            firstName:
+                type: String
+                validation:
+                    - NotBlank: ~
+                    - NotNull: ~
+            surname:
+                type: String
+                validation:
+                    - NotBlank: ~
+                    - NotNull: ~

tests/Functional/Validator/InputValidatorTest.php

@@ -87,6 +87,22 @@ public function testLinkedConstraintsValidationPasses(): void
         $this->assertTrue($result['data']['linkedConstraintsValidation']);
     }
 
+    public function testOnlyPassedFieldsValidated(): void
+    {
+        $query = '
+            mutation {
+                onlyPassedFieldsValidation(
+                    person: { firstName: "Joe" }
+                )
+            }
+        ';
+
+        $result = $this->executeGraphQLRequest($query);
+
+        $this->assertTrue(empty($result['errors']));
+        $this->assertTrue($result['data']['onlyPassedFieldsValidation']);
+    }
+
     public function testLinkedConstraintsValidationFails(): void
     {
         $query = '