Merge pull request #852 from mcg-web/remove-xml-type-config-support

Remove XML type configuration support

Author: mcg-web

UPGRADE.md

@@ -14,6 +14,7 @@ UPGRADE FROM 0.13 to 0.14
 - [Rename `ResolverInterface` to `QueryInterface`](#rename-resolverinterface-to-queryinterface)
 - [Remove Argument deprecated method](#remove-argument-deprecated-method)
 - [Remove ConnectionBuilder deprecated class](#remove-connectionbuilder-deprecated-class)
+- [Remove XML type configuration](#remove-xml-type-configuration-support)
 
 ### Customize the cursor encoder of the edges of a connection
 
@@ -216,6 +217,10 @@ Method `Overblog\GraphQLBundle\Definition\Argument::getRawArguments` is replaced
 Class `Overblog\GraphQLBundle\Relay\Connection\Output\ConnectionBuilder` is replaced by
 `Overblog\GraphQLBundle\Relay\Connection\ConnectionBuilder`.
 
+### Remove XML type configuration support
+
+XML type configuration is no longer supported.
+
 UPGRADE FROM 0.12 to 0.13
 =======================
 

docs/definitions/type-system/index.md

@@ -8,7 +8,7 @@ Types can be define 3 different ways:
 
 1. **The configuration way**
 
-    Creating this file extension **.types.yml** or **.types.xml**
+    Creating this file extension **.types.yml**
     in `src/*Bundle/Resources/config/graphql` or `app/config/graphql`.
     See the different possible types:
     * [Scalars](scalars.md)
@@ -28,7 +28,7 @@ Types can be define 3 different ways:
                 # auto_discover: false # to disable bundles and root dir auto discover
                 types:
                     -
-                        type: yaml # or xml or graphql or annotation null
+                        type: yaml # or graphql or annotation null
                         dir: "%kernel.root_dir%/.../mapping" # sub directories are also searched
                         # suffix: .types # use to change default file suffix
                     -

phpstan-baseline.neon

@@ -100,11 +100,6 @@ parameters:
 			count: 1
 			path: src/Config/Parser/GraphQLParser.php
 
-		-
-			message: "#^Parameter \\#1 \\$resource of class Symfony\\\\Component\\\\Config\\\\Resource\\\\FileResource constructor expects string, string\\|false given\\.$#"
-			count: 1
-			path: src/Config/Parser/XmlParser.php
-
 		-
 			message: "#^Parameter \\#1 \\$file of static method Symfony\\\\Component\\\\Config\\\\Util\\\\XmlUtils\\:\\:loadFile\\(\\) expects string, string\\|false given\\.$#"
 			count: 1
@@ -126,7 +121,7 @@ parameters:
 			path: src/DependencyInjection/Compiler/AliasedPass.php
 
 		-
-			message: "#^Parameter \\#1 \\$function of function call_user_func expects callable\\(\\)\\: mixed, array\\('Overblog…'\\|'Overblog…'\\|'Overblog…'\\|'Overblog…'\\|'Overblog…', 'parse'\\|'preParse'\\) given\\.$#"
+			message: "#^Parameter \\#1 \\$function of function call_user_func expects callable\\(\\)\\: mixed, array\\('Overblog…'\\|'Overblog…'\\|'Overblog…'\\|'Overblog…', 'parse'\\|'preParse'\\) given\\.$#"
 			count: 1
 			path: src/DependencyInjection/Compiler/ConfigParserPass.php
 
@@ -448,4 +443,4 @@ parameters:
 		-
 			message:  "#^Call to an undefined method ReflectionClass|ReflectionMethod|ReflectionProperty::getAttributes().$#"
 			count: 1
-			path: src/Config/Parser/AttributeParser.php
+			path: src/Config/Parser/AttributeParser.php

src/Config/Parser/XmlParser.php

@@ -9,7 +9,6 @@
 use Overblog\GraphQLBundle\Config\Parser\AttributeParser;
 use Overblog\GraphQLBundle\Config\Parser\GraphQLParser;
 use Overblog\GraphQLBundle\Config\Parser\PreParserInterface;
-use Overblog\GraphQLBundle\Config\Parser\XmlParser;
 use Overblog\GraphQLBundle\Config\Parser\YamlParser;
 use Overblog\GraphQLBundle\DependencyInjection\TypesConfiguration;
 use Overblog\GraphQLBundle\OverblogGraphQLBundle;
@@ -39,15 +38,13 @@ class ConfigParserPass implements CompilerPassInterface
 {
     public const SUPPORTED_TYPES_EXTENSIONS = [
         'yaml' => '{yaml,yml}',
-        'xml' => 'xml',
         'graphql' => '{graphql,graphqls}',
         'annotation' => 'php',
         'attribute' => 'php',
     ];
 
     public const PARSERS = [
         'yaml' => YamlParser::class,
-        'xml' => XmlParser::class,
         'graphql' => GraphQLParser::class,
         'annotation' => AnnotationParser::class,
         'attribute' => AttributeParser::class,
@@ -224,7 +221,7 @@ private function mappingFromBundles(ContainerBuilder $container): array
 
             $bundleDir = $this->bundleDir($class);
 
-            // only config files (yml or xml)
+            // only config files (yml)
             $typesMappings[] = ['dir' => $bundleDir.'/Resources/config/graphql', 'types' => null];
         }
 

src/DependencyInjection/Compiler/ConfigParserPass.php

@@ -49,13 +49,6 @@ public function testBrokenYmlOnPrepend(): void
         $this->processCompilerPass($this->getMappingConfig('yaml'));
     }
 
-    public function testBrokenXmlOnPrepend(): void
-    {
-        $this->expectException(InvalidArgumentException::class);
-        $this->expectExceptionMessageMatches('#Unable to parse file "(.*)'.preg_quote(DIRECTORY_SEPARATOR).'broken.types.xml"\.#');
-        $this->processCompilerPass($this->getMappingConfig('xml'));
-    }
-
     public function testPreparseOnPrepend(): void
     {
         $this->expectException(InvalidConfigurationException::class);

tests/DependencyInjection/Compiler/ConfigParserPassTest.php

@@ -16,5 +16,5 @@ overblog_graphql:
         mappings:
             types:
                 -
-                    type: xml
+                    type: yaml
                     dir: "%kernel.project_dir%/config/plural/mapping"

tests/DependencyInjection/mapping/xml/broken.types.xml

@@ -0,0 +1,12 @@
+Query:
+    type: object
+    config:
+        fields:
+            usernames:
+                builder: Relay::PluralIdentifyingRoot
+                builderConfig:
+                    argName: usernames
+                    description: Map from a username to the user
+                    inputType: String
+                    outputType: User
+                    resolveSingleInput: '@=query("plural_resolver", value, info)'