Allow some unused lints

We still probably don't want unused imports or variables to cause warnings,
but this codebase is large enough that warning on unconsumed errors or mut's
are a good idea.

Signed-off-by: Robert Detjens <github@detjens.dev>

Author: detjensrobert

src/builder/artifacts.rs

@@ -216,7 +216,7 @@ pub fn zip_files(archive_name: &Path, files: &[PathBuf]) -> Result<PathBuf> {
         buf.clear();
     }
 
-    z.finish();
+    z.finish()?;
 
     Ok(archive_name.to_path_buf())
 }

src/builder/docker.rs

@@ -194,7 +194,7 @@ pub async fn copy_file(container: &ContainerInfo, from: &Path, to: &Path) -> Res
 
     // extract single file from archive to disk
     // we only copied out one file, so this tar should only have one file
-    if let Some(mut entry_r) = tar.entries()?.next() {
+    if let Some(entry_r) = tar.entries()?.next() {
         let mut entry = entry_r?;
         trace!("got entry: {:?}", entry.path());
         let mut target = File::create(to)?;

src/cluster_setup/mod.rs

@@ -155,7 +155,7 @@ fn install_helm_chart(
 
     // stream output to stdout
     let reader = helm_cmd.reader()?;
-    let mut lines = BufReader::new(reader).lines();
+    let lines = BufReader::new(reader).lines();
 
     for item in lines {
         match item {

src/lib.rs

@@ -1,4 +1,4 @@
-#![allow(unused)]
+#![allow(unused_variables, unused_imports)]
 // todo!: remove ^ later
 // we dont need unused variables etc warnings while we're working on it