additional checks during rate limiter construction

Author: shalarewicz

package.json

@@ -11,7 +11,8 @@
         "lint:fix": "eslint --fix src test @types",
         "prettier": "prettier --write .",
         "prepare": "husky install",
-        "build": "tsc"
+        "build": "tsc",
+        "build:fix": "node node_modules/.bin/yab dist"
     },
     "repository": {
         "type": "git",

src/rateLimiters/fixedWindow.ts

@@ -31,7 +31,7 @@ class FixedWindow implements RateLimiter {
         this.windowSize = windowSize;
         this.client = client;
         this.keyExpiry = expiry;
-        if (windowSize <= 0 || capacity <= 0 || expiry <= 0)
+        if (!windowSize || !capacity || windowSize <= 0 || capacity <= 0 || expiry <= 0)
             throw Error('FixedWindow windowSize, capacity and keyExpiry must be positive');
     }
 
@@ -68,7 +68,7 @@ class FixedWindow implements RateLimiter {
         // attempt to get the value for the uuid from the redis cache
         const windowJSON = await this.client.get(uuid);
 
-        if (windowJSON === null) {
+        if (!windowJSON) {
             const newUserWindow: Window = {
                 currentTokens: tokens > this.capacity ? 0 : tokens,
                 fixedWindowStart: timestamp,

src/rateLimiters/slidingWindowCounter.ts

@@ -36,7 +36,7 @@ class SlidingWindowCounter implements RateLimiter {
         this.capacity = capacity;
         this.client = client;
         this.keyExpiry = expiry;
-        if (windowSize <= 0 || capacity <= 0 || expiry <= 0)
+        if (!windowSize || !capacity || windowSize <= 0 || capacity <= 0 || expiry <= 0)
             throw SyntaxError(
                 'SlidingWindowCounter window size, capacity and keyExpiry must be positive'
             );

src/rateLimiters/slidingWindowLog.ts

@@ -35,7 +35,7 @@ class SlidingWindowLog implements RateLimiter {
         this.capacity = capacity;
         this.client = client;
         this.keyExpiry = expiry;
-        if (windowSize <= 0 || capacity <= 0 || expiry <= 0)
+        if (!windowSize || !capacity || windowSize <= 0 || capacity <= 0 || expiry <= 0)
             throw SyntaxError(
                 'SlidingWindowLog window size, capacity and keyExpiry must be positive'
             );

src/rateLimiters/tokenBucket.ts

@@ -30,7 +30,7 @@ class TokenBucket implements RateLimiter {
         this.refillRate = refillRate;
         this.client = client;
         this.keyExpiry = expiry;
-        if (refillRate <= 0 || capacity <= 0 || expiry <= 0)
+        if (!refillRate || !capacity || refillRate <= 0 || capacity <= 0 || expiry <= 0)
             throw Error('TokenBucket refillRate, capacity and keyExpiry must be positive');
     }