responded to comments in PR #79

Author: evanmcneely

src/analysis/buildTypeWeights.ts

@@ -54,7 +54,7 @@ export const defaultTypeWeightsConfig: TypeWeightSet = {
  * @param {(GraphQLObjectType | GraphQLInterfaceType)} type
  * @param {TypeWeightObject} typeWeightObject
  * @param {TypeWeightSet} typeWeights
- * @param enforceBoundedLists
+ * @param {boolean} enforceBoundedLists
  * @return {*}  {Type}
  */
 function parseObjectFields(

src/utils/redis.ts

@@ -8,13 +8,9 @@ const clients: Redis[] = [];
  */
 export function connect(options: RedisOptions): Redis {
     // TODO: Figure out what other options we should set (timeouts, etc)
-    try {
-        const client: Redis = new Redis(options); // Default port is 6379 automatically
-        clients.push(client);
-        return client;
-    } catch (err) {
-        throw new Error(`Error in expressGraphQLRateLimiter when connecting to redis: ${err}`);
-    }
+    const client: Redis = new Redis(options); // Default port is 6379 automatically
+    clients.push(client);
+    return client;
 }
 
 /**

test/analysis/typeComplexityAnalysis.test.ts

@@ -871,7 +871,7 @@ describe('Test getQueryTypeComplexity function', () => {
                             }
                         }
                     }`;
-                mockCharacterFriendsFunction.mockReturnValueOnce(3);
+                expect(mockCharacterFriendsFunction).toHaveBeenCalledTimes(0);
                 // Query 1 + 1 hero + max(...Character 3, ...Human 0) = 5
                 expect(queryParser.processQuery(parse(query))).toBe(5);
 
@@ -909,7 +909,7 @@ describe('Test getQueryTypeComplexity function', () => {
                             }
                         }
                     }`;
-                mockCharacterFriendsFunction.mockReturnValueOnce(3);
+                expect(mockCharacterFriendsFunction).toHaveBeenCalledTimes(0);
                 // Query 1 + 1 hero = 2
                 expect(queryParser.processQuery(parse(query))).toBe(2);