Skip to content

Commit 7202a25

Browse files
committed
addressing changes from PR review
1 parent 4911724 commit 7202a25

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

test/analysis/buildTypeWeights.test.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -214,8 +214,10 @@ xdescribe('Test buildTypeWeightsFromSchema function', () => {
214214
Query: {
215215
weight: 1,
216216
fields: {
217-
// ? we could maybe use a closure with the type already included to make this function more easily called
217+
// FIXME: check the best solution during implementation and update the tests here.
218+
// we could maybe use a closure with the type already included to make this function more easily called
218219
reviews: (arg: number, type: Type) => arg * type.weight,
220+
// code from PR review -> reviews: (type) => args[multiplierName] * typeWeightObject[type].weight
219221
},
220222
},
221223
Review: {
@@ -247,7 +249,8 @@ xdescribe('Test buildTypeWeightsFromSchema function', () => {
247249
Human: {
248250
weight: 1,
249251
fields: {
250-
// ? we could maybe use a closure with the type already included to make this function more easily called
252+
// FIXME: check the best solution during implementation and update the tests here.
253+
// we could maybe use a closure with the type already included to make this function more easily called
251254
friends: (arg: number, type: Type) => arg * type.weight,
252255
},
253256
},

0 commit comments

Comments
 (0)