cleaned up fixme comments where they were nelorger relevent

Author: evanmcneely

src/analysis/ASTParser.ts

@@ -165,13 +165,12 @@ class ASTParser {
             // If the TypeCondition is omitted, an inline fragment is considered to be of the same type as the enclosing context
             const namedType = typeCondition ? typeCondition.name.value.toLowerCase() : parentName;
 
-            // TODO: Handle directives like @include
+            // TODO: Handle directives like @include and @skip
             // subtract 1 before, and add one after, entering the fragment selection to negate the additional level of depth added
             this.depth -= 1;
             complexity += this.selectionSetNode(node.selectionSet, namedType);
             this.depth += 1;
         } else {
-            // FIXME: Consider removing this check. SelectionNodes cannot have any other kind in the current spec.
             throw new Error(`ERROR: ASTParser.selectionNode: node type not supported`);
         }
 
@@ -239,12 +238,12 @@ class ASTParser {
                 complexity: fragmentComplexity,
                 depth: this.maxDepth - 1, // subtract one from the calculated depth of the fragment to correct for the additional depth the fragment ads to the query when used
             };
-        } else {
-            // TODO: Verify that are no other type definition nodes that need to be handled (see ast.d.ts in 'graphql')
-            // Other types include TypeSystemDefinitionNode (Schema, Type, Directvie) and
-            // TypeSystemExtensionNode(Schema, Type);
-            throw new Error(`ERROR: ASTParser.definitionNode: ${node.kind} type not supported`);
-        }
+        } // else {
+        //     // TODO: Verify that are no other type definition nodes that need to be handled (see ast.d.ts in 'graphql')
+        //     // Other types include TypeSystemDefinitionNode (Schema, Type, Directvie) and
+        //     // TypeSystemExtensionNode(Schema, Type);
+        //     throw new Error(`ERROR: ASTParser.definitionNode: ${node.kind} type not supported`);
+        // }
         return complexity;
     }
 

src/analysis/buildTypeWeights.ts

@@ -190,7 +190,7 @@ function parseObjectFields(
                 }
             }
         } else {
-            // ? what else can get through here
+            // FIXME what else can get through here
             throw new Error(`ERROR: buildTypeWeight: Unsupported field type: ${fieldType}`);
         }
     });

src/middleware/index.ts

@@ -21,7 +21,6 @@ import ASTParser from '../analysis/ASTParser';
  *      , "depthLimit: number" will block queries with deeper nesting than the specified depth. Will not block queries by depth by default
  * @returns {RequestHandler} express middleware that computes the complexity of req.query and calls the next middleware
  * if the query is allowed or sends a 429 status if the request is blocked
- * FIXME: How about the specific GraphQLError?
  * @throws Error
  */
 export default function expressGraphQLRateLimiter(

src/rateLimiters/tokenBucket.ts

@@ -111,7 +111,7 @@ class TokenBucket implements RateLimiter {
         timestamp: number
     ): number => {
         const timeSinceLastQueryInSeconds: number = Math.floor(
-            (timestamp - bucket.timestamp) / 1000 // 1000 ms in a second // FIXME: magic number if specifying custom timeframe
+            (timestamp - bucket.timestamp) / 1000 // 1000 ms in a second
         );
         const tokensToAdd = timeSinceLastQueryInSeconds * this.refillRate;
         const updatedTokenCount = bucket.tokens + tokensToAdd;

src/utils/redis.ts

@@ -8,7 +8,6 @@ const clients: Redis[] = [];
  */
 export function connect(options: RedisOptions): Redis {
     // TODO: Figure out what other options we should set (timeouts, etc)
-    // TODO: pass on connection error
     try {
         const client: Redis = new Redis(options); // Default port is 6379 automatically
         clients.push(client);