Skip to content

Commit 572987a

Browse files
committed
Fixed test for negative tokenbucket refillRate and capacity
1 parent ee63bb7 commit 572987a

File tree

1 file changed

+13
-5
lines changed

1 file changed

+13
-5
lines changed

test/rateLimiters/tokenBucket.test.ts

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { RedisClientType } from 'redis';
33
import TokenBucket from '../../src/rateLimiters/tokenBucket';
44

55
const CAPACITY = 10;
6-
// FIXME: Changing the refill rate affects test outcomes.
6+
// FIXME: Changing the refill rate effects test outcomes.
77
const REFILL_RATE = 1; // 1 token per second
88

99
let limiter: TokenBucket;
@@ -199,10 +199,18 @@ describe('Test TokenBucket Rate Limiter', () => {
199199
});
200200

201201
test('bucket does not allow capacity or refill rate <= 0', () => {
202-
expect(new TokenBucket(-10, 1, client)).toThrowError();
203-
expect(new TokenBucket(0, 1, client)).toThrowError();
204-
expect(new TokenBucket(10, -1, client)).toThrowError();
205-
expect(new TokenBucket(10, 0, client)).toThrowError();
202+
expect(() => new TokenBucket(0, 1, client)).toThrow(
203+
'TokenBucket refillRate and capacity must be positive'
204+
);
205+
expect(() => new TokenBucket(-10, 1, client)).toThrow(
206+
'TokenBucket refillRate and capacity must be positive'
207+
);
208+
expect(() => new TokenBucket(10, -1, client)).toThrow(
209+
'TokenBucket refillRate and capacity must be positive'
210+
);
211+
expect(() => new TokenBucket(10, 0, client)).toThrow(
212+
'TokenBucket refillRate and capacity must be positive'
213+
);
206214
});
207215

208216
test('All buckets should be able to be reset', async () => {

0 commit comments

Comments
 (0)