Merge branch 'dev' into em/complexityTests

Author: evanmcneely

test/analysis/buildTypeWeights.test.ts

@@ -2,6 +2,8 @@ import { buildSchema } from 'graphql';
 import { GraphQLSchema } from 'graphql/type/schema';
 import buildTypeWeightsFromSchema from '../../src/analysis/buildTypeWeights';
 
+
+// these types allow the tests to overwite properties on the typeWeightObject
 interface TestFields {
     [index: string]: number;
 }
@@ -196,8 +198,7 @@ xdescribe('Test buildTypeWeightsFromSchema function', () => {
             });
         });
 
-        // ? varibale weight
-        test('fields returning lists of objects', () => {
+        test('fields returning lists of objects of determinate size', () => {
             schema = buildSchema(`
                 type Query {
                     reviews(episode: Episode!, first: Int): [Review]
@@ -215,13 +216,17 @@ xdescribe('Test buildTypeWeightsFromSchema function', () => {
             expect(buildTypeWeightsFromSchema(schema)).toEqual({
                 Query: {
                     weight: 1,
-                    fields: {},
+                    fields: {
+                        // FIXME: check the best solution during implementation and update the tests here.
+                        reviews: (arg: number, type: Type) => arg * type.weight,
+                        // code from PR review -> reviews: (type) => args[multiplierName] * typeWeightObject[type].weight
+                    },
                 },
                 Review: {
-                    weight: 1, // ? weight is the argument passed as 'first'. it's variable...
+                    weight: 1,
                     fields: {
-                        id: 0,
-                        name: 0,
+                        stars: 0,
+                        commentary: 0,
                     },
                 },
                 Episode: {
@@ -231,44 +236,63 @@ xdescribe('Test buildTypeWeightsFromSchema function', () => {
             });
         });
 
+        // TODO: need to figure out how to handle this situation. Skip for now.
+        // The field friends returns a list of an unknown number of objects.
+        xtest('fields returning lists of objects of indetermitae size', () => {
+            schema = buildSchema(`
+                type Human {
+                    id: ID!
+                    name: String!
+                    homePlanet: String
+                    friends: [Human]
+                }
+            `);
+            expect(buildTypeWeightsFromSchema(schema)).toEqual({
+                Human: {
+                    weight: 1,
+                    fields: {
+                        // FIXME: check the best solution during implementation and update the tests here.
+                        friends: (arg: number, type: Type) => arg * type.weight,
+                    },
+                },
+            });
+        });
+
         test('interface types', () => {
             schema = buildSchema(`
                 interface Character {
                     id: ID!
-                    name: String!
-                    friends: [Character]
+                    name: String!                    
                 }
             
                 type Human implements Character {
                     id: ID!
                     name: String!
                     homePlanet: String
-                    friends: [Character]
                 }
             
                 type Droid implements Character {
                     id: ID!
-                    name: String!
-                    friends: [Character]
+                    name: String!                
                     primaryFunction: String
                 }`);
             expect(buildTypeWeightsFromSchema(schema)).toEqual({
-                character: {
+                Character: {
                     weight: 1,
                     fields: {
                         id: 0,
                         name: 0,
                     },
                 },
-                human: {
+                Human: {
                     weight: 1,
                     fields: {
                         id: 0,
                         name: 0,
                         homePlanet: 0,
                     },
                 },
-                droid: {
+                Droid: {
                     weight: 1,
                     fields: {
                         id: 0,