Skip to content

Commit 1e67be0

Browse files
committed
corrected query complexity for express tests
1 parent f4c4c6c commit 1e67be0

File tree

1 file changed

+13
-17
lines changed

1 file changed

+13
-17
lines changed

test/middleware/express.test.ts

Lines changed: 13 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -207,20 +207,17 @@ xdescribe('Express Middleware tests', () => {
207207

208208
complexRequest = {
209209
// complexity should be 10 if 'first' is accounted for.
210-
// scalars: 1, droid: 1, reviews 8: 1)
210+
// Query: 1, droid: 1, reviews 8: 1)
211211
query: {
212212
query: `Query {
213-
scalars: {
214-
num
215-
}
216-
droid(id: 1) {
217-
name
218-
}
219-
reviews(episode: 'NEWHOPE', first: 8) {
220-
episode
221-
stars
222-
commentary
223-
}
213+
droid(id: 1) {
214+
name
215+
}
216+
reviews(episode: 'NEWHOPE', first: 8) {
217+
episode
218+
stars
219+
commentary
220+
}
224221
`,
225222
},
226223
};
@@ -284,9 +281,9 @@ xdescribe('Express Middleware tests', () => {
284281

285282
describe('BLOCKS requests', () => {
286283
test('A single request that exceeds capacity', () => {
287-
complexRequest = {
284+
const blockedRequest: Partial<Request> = {
288285
// complexity should be 12 if 'first' is accounted for.
289-
// scalars: 1, droid: 1, reviews (5 * (1 Review, 1 episode))
286+
// scalars: 1, droid: 1, reviews (10 * (1 Review, 0 episode))
290287
query: {
291288
query: `Query {
292289
scalars: {
@@ -295,7 +292,7 @@ xdescribe('Express Middleware tests', () => {
295292
droid(id: 1) {
296293
name
297294
}
298-
reviews(episode: 'NEWHOPE', first: 5) {
295+
reviews(episode: 'NEWHOPE', first: 10) {
299296
episode
300297
stars
301298
commentary
@@ -304,8 +301,7 @@ xdescribe('Express Middleware tests', () => {
304301
},
305302
};
306303

307-
middleware(mockRequest as Request, mockResponse as Response, nextFunction);
308-
// FIXME: status is a function. Where does 439 actaully get set.
304+
middleware(blockedRequest as Request, mockResponse as Response, nextFunction);
309305
expect(mockResponse.statusCode).toBe(429);
310306
expect(nextFunction).not.toBeCalled();
311307

0 commit comments

Comments
 (0)