Skip to content

Commit 11de437

Browse files
committed
comment cleanup for type weight tests
1 parent 6e6a4fd commit 11de437

File tree

1 file changed

+3
-10
lines changed

1 file changed

+3
-10
lines changed

test/analysis/buildTypeWeights.test.ts

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -212,18 +212,11 @@ describe('Test buildTypeWeightsFromSchema function', () => {
212212
JEDI
213213
}`);
214214

215-
function reviews(multiplier: number): number {
216-
return 1;
217-
}
218-
219-
// TODO: Add tests for what the function does
220215
expect(buildTypeWeightsFromSchema(schema)).toEqual({
221216
query: {
222217
weight: 1,
223218
fields: {
224-
// FIXME: check the best solution during implementation and update the tests here.
225-
reviews: expect.any(Function), // FIXME: Better way to test this?
226-
// code from PR review -> reviews: (type) => args[multiplierName] * typeWeightObject[type].weight
219+
reviews: expect.any(Function), // TODO: Test this function separately
227220
},
228221
},
229222
review: {
@@ -255,8 +248,8 @@ describe('Test buildTypeWeightsFromSchema function', () => {
255248
human: {
256249
weight: 1,
257250
fields: {
258-
// FIXME: check the best solution during implementation and update the tests here.
259-
friends: (arg: number, type: Type) => arg * type.weight,
251+
// TODO: Test this function separately.
252+
friends: expect.any(Function),
260253
},
261254
},
262255
});

0 commit comments

Comments
 (0)