4680: Applied coding standards

Author: tuj

CHANGELOG.md

@@ -4,7 +4,7 @@ All notable changes to this project will be documented in this file.
 
 ## [Unreleased]
 
-- [#244](https://github.com/os2display/display-api-service/pull/244)
+- [#245](https://github.com/os2display/display-api-service/pull/245)
   - Added resource endpoint for limiting access to instant book interactive slide.
 - [#243](https://github.com/os2display/display-api-service/pull/243)
   - Changed resource name in calendar api feed type resource selector.

src/InteractiveSlide/InstantBook.php

@@ -9,7 +9,6 @@
 use App\Entity\Tenant\InteractiveSlide;
 use App\Entity\Tenant\Slide;
 use App\Entity\User;
-use App\Exceptions\InteractiveSlideException;
 use App\Service\InteractiveSlideService;
 use App\Service\KeyVaultService;
 use Psr\Cache\CacheItemInterface;
@@ -256,7 +255,7 @@ private function createEntry(string $resource, array $schedules, string $startFo
      */
     private function quickBook(Slide $slide, InteractionSlideRequest $interactionRequest): array
     {
-        $resource = $this->getValueFromInterval('resource', $interactionRequest);
+        $resource = (string) $this->getValueFromInterval('resource', $interactionRequest);
         $durationMinutes = $this->getValueFromInterval('durationMinutes', $interactionRequest);
 
         $now = new \DateTime();
@@ -446,8 +445,9 @@ private function getHeaders(string $token): array
 
     private function checkPermission(InteractiveSlide $interactive, string $resource): void
     {
+        $configuration = $interactive->getConfiguration();
         // Optional limiting of available resources.
-        if (!empty($interactive->getConfiguration()['resourceEndpoint'])) {
+        if (null !== $configuration && !empty($configuration['resourceEndpoint'])) {
             $allowedResources = $this->getAllowedResources($interactive);
 
             if (!in_array($resource, $allowedResources)) {
@@ -458,20 +458,31 @@ private function checkPermission(InteractiveSlide $interactive, string $resource
 
     private function getAllowedResources(InteractiveSlide $interactive): array
     {
-        return $this->interactiveSlideCache->get(self::CACHE_ALLOWED_RESOURCES_PREFIX . $interactive->getId(), function (CacheItemInterface $item) use ($interactive) {
+        return $this->interactiveSlideCache->get(self::CACHE_ALLOWED_RESOURCES_PREFIX.$interactive->getId(), function (CacheItemInterface $item) use ($interactive) {
             $item->expiresAfter(60 * 60);
 
             $configuration = $interactive->getConfiguration();
-            $resourceEndpoint = $this->keyValueService->getValue($configuration['resourceEndpoint']);
+
+            $key = $configuration['resourceEndpoint'] ?? null;
+
+            if (null === $key) {
+                throw new \Exception('resourceEndpoint not set');
+            }
+
+            $resourceEndpoint = $this->keyValueService->getValue($key);
+
+            if (null === $resourceEndpoint) {
+                throw new \Exception('resourceEndpoint value not set');
+            }
 
             $response = $this->client->request('GET', $resourceEndpoint);
             $content = $response->toArray();
 
             $allowedResources = [];
 
             foreach ($content as $resource) {
-                if ($resource["allowInstantBooking"] === 'True') {
-                    $allowedResources[] = $resource["ResourceMail"];
+                if ('True' === $resource['allowInstantBooking']) {
+                    $allowedResources[] = $resource['ResourceMail'];
                 }
             }