Merge pull request #460 from orottier/bugfix/audioparam-end-time-rounding

AudioParam end time calculation, use round instead of ceil

Author: orottier

src/param.rs

@@ -1060,7 +1060,7 @@ impl AudioParamProcessor {
 
         // fill buffer with current intrinsic value until `event.time`
         if infos.is_a_rate {
-            let end_index = ((time - infos.block_time).max(0.) / infos.dt) as usize;
+            let end_index = ((time - infos.block_time).max(0.) / infos.dt).round() as usize;
             let end_index_clipped = end_index.min(infos.count);
 
             for _ in self.buffer.len()..end_index_clipped {
@@ -1110,9 +1110,9 @@ impl AudioParamProcessor {
 
         if infos.is_a_rate {
             let start_index = self.buffer.len();
-            // we need to `ceil()` because if `end_time` is between two samples
-            // we actually want the sample before `end_time` to be computed
-            let end_index = ((end_time - infos.block_time).max(0.) / infos.dt).ceil() as usize;
+            // TODO use ceil() or round() when `end_time` is between two samples?
+            // <https://github.com/orottier/web-audio-api-rs/pull/460>
+            let end_index = ((end_time - infos.block_time).max(0.) / infos.dt).round() as usize;
             let end_index_clipped = end_index.min(infos.count);
 
             // compute "real" value according to `t` then clamp it
@@ -1212,10 +1212,9 @@ impl AudioParamProcessor {
 
         if infos.is_a_rate {
             let start_index = self.buffer.len();
-            // we need to `ceil()` because if `end_time` is between two samples
-            // we actually want the sample before `end_time` to be computed
-            // @todo - more tests
-            let end_index = ((end_time - infos.block_time).max(0.) / infos.dt).ceil() as usize;
+            // TODO use ceil() or round() when `end_time` is between two samples?
+            // <https://github.com/orottier/web-audio-api-rs/pull/460>
+            let end_index = ((end_time - infos.block_time).max(0.) / infos.dt).round() as usize;
             let end_index_clipped = end_index.min(infos.count);
 
             if end_index_clipped > start_index {
@@ -1338,10 +1337,9 @@ impl AudioParamProcessor {
 
         if infos.is_a_rate {
             let start_index = self.buffer.len();
-            // we need to `ceil()` because if `end_time` is between two samples
-            // we actually want the sample before `end_time` to be computed
-            // @todo - more tests
-            let end_index = ((end_time - infos.block_time).max(0.) / infos.dt).ceil() as usize;
+            // TODO use ceil() or round() when `end_time` is between two samples?
+            // <https://github.com/orottier/web-audio-api-rs/pull/460>
+            let end_index = ((end_time - infos.block_time).max(0.) / infos.dt).round() as usize;
             let end_index_clipped = end_index.min(infos.count);
 
             if end_index_clipped > start_index {
@@ -1439,10 +1437,9 @@ impl AudioParamProcessor {
 
         if infos.is_a_rate {
             let start_index = self.buffer.len();
-            // we need to `ceil()` because if `end_time` is between two samples
-            // we actually want the sample before `end_time` to be computed
-            // @todo - more tests
-            let end_index = ((end_time - infos.block_time).max(0.) / infos.dt).ceil() as usize;
+            // TODO use ceil() or round() when `end_time` is between two samples?
+            // <https://github.com/orottier/web-audio-api-rs/pull/460>
+            let end_index = ((end_time - infos.block_time).max(0.) / infos.dt).round() as usize;
             let end_index_clipped = end_index.min(infos.count);
 
             if end_index_clipped > start_index {