♻️ Refactor gatsby-node.js

Author: Sergei Orlov

gatsby-node.js

@@ -1,68 +1,23 @@
 const { getPages } = require("./src/notion-api/get-pages")
+const { getNotionPageProperties } = require("./src/transformers/get-page-properties")
+const { getNotionPageTitle } = require("./src/transformers/get-page-title")
 
 const NODE_TYPE = "Notion"
 
 exports.sourceNodes = async (
 	{ actions, createContentDigest, createNodeId, reporter },
 	pluginOptions,
 ) => {
-	const { createNode } = actions
+	const pages = await getPages(
+		{ token: pluginOptions.token, databaseId: pluginOptions.databaseId },
+		reporter,
+	)
 
-	const data = {
-		pages: await getPages(pluginOptions, reporter),
-	}
-
-	data.pages.forEach((page) => {
-		const properties = Object.keys(page.properties).reduce((acc, key) => {
-			if (page.properties[key].type == "title") {
-				return acc
-			}
-
-			return {
-				...acc,
-				[key]: {
-					id: page.properties[key].id,
-					key,
-					value: page.properties[key][page.properties[key].type],
-					type: page.properties[key].type,
-				},
-			}
-		}, {})
-
-		const titleProperty = Object.keys(page.properties).find(
-			(key) => page.properties[key].type == "title",
-		)
-
-		const title = page.properties[titleProperty].title.reduce((acc, chunk) => {
-			if (chunk.type == "text") {
-				return acc.concat(chunk.plain_text)
-			}
-
-			if (chunk.type == "mention") {
-				if (chunk.mention.type == "user") {
-					return acc.concat(chunk.mention.user.name)
-				}
-
-				if (chunk.mention.type == "date") {
-					if (chunk.mention.date.end) {
-						return acc.concat(`${chunk.mention.date.start} → ${chunk.mention.date.start}`)
-					}
-
-					return acc.concat(chunk.mention.date.start)
-				}
-
-				if (chunk.mention.type == "page") {
-					return acc.concat(chunk.plain_text)
-				}
-			}
-
-			return acc
-		}, "")
-
-		createNode({
+	pages.forEach((page) => {
+		actions.createNode({
 			id: createNodeId(`${NODE_TYPE}-${page.id}`),
-			title: title.trim(),
-			properties,
+			title: getNotionPageTitle(page),
+			properties: getNotionPageProperties(page),
 			archived: page.archived,
 			createdAt: page.created_time,
 			updatedAt: page.last_edited_time,

src/transformers/get-page-properties.js

@@ -0,0 +1,16 @@
+exports.getNotionPageProperties = (page) =>
+	Object.keys(page.properties).reduce((acc, key) => {
+		if (page.properties[key].type == "title") {
+			return acc
+		}
+
+		return {
+			...acc,
+			[key]: {
+				id: page.properties[key].id,
+				key,
+				value: page.properties[key][page.properties[key].type],
+				type: page.properties[key].type,
+			},
+		}
+	}, {})

src/transformers/get-page-title.js

@@ -0,0 +1,33 @@
+exports.getNotionPageTitle = (page) => {
+	const titleProperty = Object.keys(page.properties).find(
+		(key) => page.properties[key].type == "title",
+	)
+
+	return page.properties[titleProperty].title
+		.reduce((acc, chunk) => {
+			if (chunk.type == "text") {
+				return acc.concat(chunk.plain_text)
+			}
+
+			if (chunk.type == "mention") {
+				if (chunk.mention.type == "user") {
+					return acc.concat(chunk.mention.user.name)
+				}
+
+				if (chunk.mention.type == "date") {
+					if (chunk.mention.date.end) {
+						return acc.concat(`${chunk.mention.date.start} → ${chunk.mention.date.start}`)
+					}
+
+					return acc.concat(chunk.mention.date.start)
+				}
+
+				if (chunk.mention.type == "page") {
+					return acc.concat(chunk.plain_text)
+				}
+			}
+
+			return acc
+		}, "")
+		.trim()
+}