Skip to content

Commit e775149

Browse files
Copilotdannystaple
andcommitted
Address PR feedback: rename dockerfile, add EOF newline, exclude docs from build
Co-authored-by: dannystaple <426859+dannystaple@users.noreply.github.com>
1 parent e7063cf commit e775149

File tree

4 files changed

+9
-8
lines changed

4 files changed

+9
-8
lines changed

.eleventyignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,3 +4,4 @@
44
./tests
55

66
Dockerfile
7+
DOCKER_OPTIMIZATION.md

DOCKER_OPTIMIZATION.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,11 @@ The original setup transferred the entire repository (425MB including galleries/
1212
Created optimized Docker setup:
1313

1414
### Files Added
15-
- `Dockerfile.dev` - Minimal dockerfile that only installs npm dependencies
15+
- `dev.Dockerfile` - Minimal dockerfile that only installs npm dependencies
1616
- Updated `.dockerignore` - Aggressive exclusion of large directories
1717

1818
### Changes Made
19-
- `docker-compose.yml` - Updated serve, dist, build, and shell services to use `Dockerfile.dev`
19+
- `docker-compose.yml` - Updated serve, dist, build, and shell services to use `dev.Dockerfile`
2020
- Original `Dockerfile` - Kept for production services that need full content (httpd_serve, staging, etc.)
2121

2222
### Performance Improvement
@@ -25,7 +25,7 @@ Created optimized Docker setup:
2525

2626
## Architecture
2727

28-
### Development Services (use Dockerfile.dev)
28+
### Development Services (use dev.Dockerfile)
2929
- `serve` - Eleventy development server
3030
- `dist` - Webpack asset bundling
3131
- `build` - Site generation

Dockerfile.dev renamed to dev.Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,4 +22,4 @@ RUN apt-get update && apt-get install -y \
2222
# Source code will be volume-mounted at runtime
2323

2424
# Default stage - just npm dependencies installed
25-
FROM base
25+
FROM base

docker-compose.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ services:
22
serve:
33
build:
44
context: .
5-
dockerfile: Dockerfile.dev
5+
dockerfile: dev.Dockerfile
66
command: ["npm", "run", "serve"]
77
volumes:
88
- .:/app/src
@@ -16,7 +16,7 @@ services:
1616
dist:
1717
build:
1818
context: .
19-
dockerfile: Dockerfile.dev
19+
dockerfile: dev.Dockerfile
2020
command: ["npm", "run", "dist"]
2121
volumes:
2222
- .:/app/src
@@ -25,7 +25,7 @@ services:
2525
build:
2626
build:
2727
context: .
28-
dockerfile: Dockerfile.dev
28+
dockerfile: dev.Dockerfile
2929
command: ["npm", "run", "11ty"]
3030
volumes:
3131
- .:/app/src
@@ -61,7 +61,7 @@ services:
6161
shell:
6262
build:
6363
context: .
64-
dockerfile: Dockerfile.dev
64+
dockerfile: dev.Dockerfile
6565
target: debug
6666
command: ["bash"]
6767
volumes:

0 commit comments

Comments
 (0)