Merge branch 'wrc-label-fix' into 'main'

WRC label fix

See merge request weblogic-cloud/weblogic-toolkit-ui!304

Author: robertpatrick

THIRD_PARTY_LICENSES.txt

@@ -1,5 +1,5 @@
 +++
-title = "Release Notes 1.6.0"
+title = "Release 1.6.0"
 date = 2022-11-03T12:48:00-05:00
 weight = 90
 pre = "<b> </b>"

documentation/1.7/content/release/release-1.6.0.md

@@ -1,7 +1,7 @@
 +++
 title = "Release 1.6.3"
 date = 2022-11-03T12:48:00-05:00
-weight = 88
+weight = 87
 pre = "<b> </b>"
 +++
 

documentation/1.7/content/release/release-1.6.3.md

@@ -9,4 +9,5 @@
 /Library
 /.env
 /app/webui.json
+/app/locales/en/*.missing.json
 /coverage

electron/.eslintrc.json

@@ -3,7 +3,12 @@
  * Copyright (c) 2021, Oracle and/or its affiliates.
  * Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl.
  */
-const crypto = require('crypto');
+const {
+  createCipheriv,
+  createDecipheriv,
+  pbkdf2Sync,
+  randomBytes
+} = require('node:crypto');
 const zlib = require('zlib');
 
 const _ivLength = 16;
@@ -20,11 +25,11 @@ class CredentialEncryptor {
   }
 
   getEncryptedText(clearText) {
-    const salt = crypto.randomBytes(_saltLength);
+    const salt = randomBytes(_saltLength);
     const derivedKey = this._getDerivedKey(salt);
 
-    const iv = crypto.randomBytes(_ivLength);
-    const cipher = crypto.createCipheriv(_encryptionAlgorithm, derivedKey, iv);
+    const iv = randomBytes(_ivLength);
+    const cipher = createCipheriv(_encryptionAlgorithm, derivedKey, iv);
     const encrypted = Buffer.concat([ cipher.update(clearText, 'utf8'), cipher.final() ]);
     let authTag = cipher.getAuthTag();
 
@@ -39,7 +44,7 @@ class CredentialEncryptor {
     const salt = Buffer.from(data.salt, 'base64');
     const derivedKey = this._getDerivedKey(salt);
 
-    const decipher = crypto.createDecipheriv(_encryptionAlgorithm, derivedKey, iv);
+    const decipher = createDecipheriv(_encryptionAlgorithm, derivedKey, iv);
     decipher.setAuthTag(authTag);
     const decrypted = Buffer.concat([decipher.update(encrypted), decipher.final()]);
     return decrypted.toString('utf8');
@@ -48,7 +53,7 @@ class CredentialEncryptor {
   _getDerivedKey(salt) {
     // derive key with password and salt
     // keylength adheres to the "ECRYPT-CSA Recommendations" on "www.keylength.com"
-    return crypto.pbkdf2Sync(this.passphrase, salt, _iterations, _keyLength, _digestAlgorithm);
+    return pbkdf2Sync(this.passphrase, salt, _iterations, _keyLength, _digestAlgorithm);
   }
 
   _packCipherData(authTag, content, iv, salt) {

electron/.gitignore

@@ -1,6 +1,6 @@
 /**
  * @license
- * Copyright (c) 2021, 2023, Oracle and/or its affiliates.
+ * Copyright (c) 2021, 2024, Oracle and/or its affiliates.
  * Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl.
  */
 const CredentialEncryptor = require('./credentialEncryptor');
@@ -9,7 +9,6 @@ const { getLogger } = require('./wktLogging');
 
 const DECRYPTION_FAILED_STRING = 'Unsupported state or unable to authenticate data';
 
-/* global Buffer */
 class CredentialManager {
   constructor(credentialStorePolicy) {
     this.credentialStorePolicy = credentialStorePolicy;
@@ -57,63 +56,17 @@ class CredentialManager {
           refObj.reference = { };
         }
         const cipherText = refObj.reference[refObj.field];
-        refObj.reference[refObj.field] = await this.manager.loadCredential(jsonPath, cipherText);
+        if (cipherText) {
+          refObj.reference[refObj.field] = await this.manager.loadCredential(jsonPath, cipherText);
+        } else {
+          logger.debug('Failed to load credential from %s so skipping it', jsonPath);
+        }
       }
     }
     return Promise.resolve(loadedProject);
   }
 }
 
-class CredentialStoreManager extends CredentialManager {
-  constructor(projectGuid) {
-    super('native');
-    const CredentialStore = require('./credentialStore');
-
-    this.projectGuid = projectGuid;
-    this.credentialStore = new CredentialStore();
-    super.credentialManager = this;
-  }
-
-  get credentialStoreType() {
-    return super.credentialStoreType;
-  }
-
-  async storeCredentials(project) {
-    return super.storeCredentials(project);
-  }
-
-  async loadCredentials(project) {
-    return super.loadCredentials(project);
-  }
-
-  async storeCredential(jsonPath, clearText) {
-    return new Promise((resolve, reject) => {
-      if (clearText) {
-        this.credentialStore.storeCredential(this._getCredentialName(jsonPath), clearText)
-          .then(() => resolve())
-          .catch(err => reject(new Error(`Failed to save credential for ${jsonPath}: ${err}`)));
-      } else {
-        this.credentialStore.deleteCredential(this._getCredentialName(jsonPath))
-          .then(() => resolve())
-          .catch(err => reject(new Error(`Failed to delete empty credential for ${jsonPath}: ${err}`)));
-      }
-    });
-  }
-
-  // eslint-disable-next-line no-unused-vars
-  async loadCredential(jsonPath, cipherText) {
-    return new Promise((resolve, reject) => {
-      this.credentialStore.getCredential(this._getCredentialName(jsonPath))
-        .then(clearText => resolve(clearText))
-        .catch(err => reject(new Error(`Failed to load credential for ${jsonPath}: ${err}`)));
-    });
-  }
-
-  _getCredentialName(jsonPath) {
-    return Buffer.from(`${this.projectGuid}:${jsonPath}`, 'utf8').toString('base64');
-  }
-}
-
 class EncryptedCredentialManager extends CredentialManager {
   static BAD_PASSPHRASE_KEY = 'Incorrect passphrase';
 
@@ -199,6 +152,5 @@ class CredentialNoStoreManager extends CredentialManager {
 
 module.exports = {
   CredentialNoStoreManager,
-  CredentialStoreManager,
   EncryptedCredentialManager
 };

electron/app/js/credentialEncryptor.js

@@ -3,6 +3,7 @@
  * Copyright (c) 2021, Oracle and/or its affiliates.
  * Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl.
  */
+// eslint-disable-next-line no-redeclare
 const { name } = require('../../package.json');
 const { getLogger } = require('./wktLogging');
 

electron/app/js/credentialManager.js

@@ -209,12 +209,12 @@ function getExecutableFilePath(exeName, mode) {
   let resolvedPath;
   try {
     resolvedPath = which.sync(exeName);
-  } catch (err) {
+  } catch {
     // not found...
     if (osUtils.isMac() && mode === 'exe') {
       try {
         resolvedPath = which.sync(exeName, { path: '/usr/local/bin' });
-      } catch (nestedErr) {
+      } catch {
         // still not found...
       }
     }

electron/app/js/credentialStore.js

@@ -6,6 +6,11 @@
 'use strict';
 
 const { HttpsProxyAgent } = require('https-proxy-agent');
+
+// Node.js now has a built-in fetch implementation but it does not appear to
+// support proxies so let's stick with node-fetch for now...
+//
+// eslint-disable-next-line no-redeclare
 const fetch = require('node-fetch');
 
 // WARNING: This file contains functions that are called by build scripts